chrome/browser/extensions/webstore_install_with_prompt.cc - Issue 313203004: Make ExtensionInstallPrompt::Prompt ref-counted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_install_with_prompt.cc

Issue 313203004: Make ExtensionInstallPrompt::Prompt ref-counted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest master for CQ Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_install_with_prompt.cc

diff --git a/chrome/browser/extensions/webstore_install_with_prompt.cc b/chrome/browser/extensions/webstore_install_with_prompt.cc

index 4a43388fe142def24eaec57dbc3c4df9ea426cb7..19ab6148729884518dde45ad9c6711fababffbbd 100644

--- a/chrome/browser/extensions/webstore_install_with_prompt.cc

+++ b/chrome/browser/extensions/webstore_install_with_prompt.cc

@@ -50,12 +50,10 @@ const GURL& WebstoreInstallWithPrompt::GetRequestorURL() const {

return dummy_requestor_url_;

}

-scoped_ptr<ExtensionInstallPrompt::Prompt>

+scoped_refptr<ExtensionInstallPrompt::Prompt>

WebstoreInstallWithPrompt::CreateInstallPrompt() const {

- scoped_ptr<ExtensionInstallPrompt::Prompt> prompt(

- new ExtensionInstallPrompt::Prompt(

- ExtensionInstallPrompt::INSTALL_PROMPT));

- return prompt.Pass();

+ return new ExtensionInstallPrompt::Prompt(

+ ExtensionInstallPrompt::INSTALL_PROMPT);

}

scoped_ptr<ExtensionInstallPrompt>