Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4568)

Unified Diff: chrome/browser/apps/ephemeral_app_launcher.cc

Issue 313203004: Make ExtensionInstallPrompt::Prompt ref-counted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Latest master for CQ Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/ephemeral_app_launcher.h ('k') | chrome/browser/chromeos/file_manager/app_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/ephemeral_app_launcher.cc
diff --git a/chrome/browser/apps/ephemeral_app_launcher.cc b/chrome/browser/apps/ephemeral_app_launcher.cc
index d46942ea85cc8d7ca2bfc8e3a8dc5a7ae81a6462..90c4482e2f807e7a18095efd18d11a5a7d9f445e 100644
--- a/chrome/browser/apps/ephemeral_app_launcher.cc
+++ b/chrome/browser/apps/ephemeral_app_launcher.cc
@@ -156,7 +156,7 @@ WebContents* EphemeralAppLauncher::GetWebContents() const {
return web_contents() ? web_contents() : dummy_web_contents_.get();
}
-scoped_ptr<ExtensionInstallPrompt::Prompt>
+scoped_refptr<ExtensionInstallPrompt::Prompt>
EphemeralAppLauncher::CreateInstallPrompt() const {
DCHECK(extension_.get() != NULL);
@@ -165,9 +165,9 @@ EphemeralAppLauncher::CreateInstallPrompt() const {
extensions::PermissionMessages permissions =
extension_->permissions_data()->GetPermissionMessages();
if (permissions.empty())
- return scoped_ptr<ExtensionInstallPrompt::Prompt>();
+ return NULL;
- return make_scoped_ptr(new ExtensionInstallPrompt::Prompt(
+ return make_scoped_refptr(new ExtensionInstallPrompt::Prompt(
ExtensionInstallPrompt::LAUNCH_PROMPT));
}
« no previous file with comments | « chrome/browser/apps/ephemeral_app_launcher.h ('k') | chrome/browser/chromeos/file_manager/app_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698