Make ExtensionInstallPrompt::Prompt ref-counted

chrome/browser/extensions/extension_install_prompt.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
 
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/files/file_path.h"
+#include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/extensions/crx_installer_error.h"
 #include "chrome/browser/extensions/extension_install_prompt_experiment.h"
 #include "extensions/common/url_pattern.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/native_widget_types.h"
@@ skipping 46 matching lines @@
 
   enum DetailsType {
     PERMISSIONS_DETAILS = 0,
     RETAINED_FILES_DETAILS,
   };
 
   // Extra information needed to display an installation or uninstallation
   // prompt. Gets populated with raw data and exposes getters for formatted
   // strings so that the GTK/views/Cocoa install dialogs don't have to repeat
   // that logic.
-  class Prompt {
+  // Ref-counted because we pass around the prompt independent of the full
+  // ExtensionInstallPrompt.
+  class Prompt : public base::RefCountedThreadSafe<Prompt> {
    public:
     explicit Prompt(PromptType type);
-    ~Prompt();
 
     // Sets the permission list for this prompt.
     void SetPermissions(const std::vector<base::string16>& permissions);
     // Sets the permission list details for this prompt.
     void SetPermissionsDetails(const std::vector<base::string16>& details);
     void SetIsShowingDetails(DetailsType type,
                              size_t index,
                              bool is_showing_details);
     void SetWebstoreData(const std::string& localized_user_count,
                          bool show_user_count,
@@ skipping 60 matching lines @@
     bool has_webstore_data() const { return has_webstore_data_; }
 
     const ExtensionInstallPromptExperiment* experiment() const {
       return experiment_;
     }
     void set_experiment(ExtensionInstallPromptExperiment* experiment) {
       experiment_ = experiment;
     }
 
    private:
+    friend class base::RefCountedThreadSafe<Prompt>;
+
+    virtual ~Prompt();
+
     bool ShouldDisplayRevokeFilesButton() const;
 
     PromptType type_;
 
     // Permissions that are being requested (may not be all of an extension's
     // permissions if only additional ones are being requested)
     std::vector<base::string16> permissions_;
     std::vector<base::string16> details_;
     std::vector<bool> is_showing_details_for_permissions_;
     bool is_showing_details_for_retained_files_;
@@ skipping 17 matching lines @@
     // false if localized_user_count_ represents the number zero).
     bool show_user_count_;
 
     // Whether or not this prompt has been populated with data from the
     // webstore.
     bool has_webstore_data_;
 
     std::vector<base::FilePath> retained_files_;
 
     scoped_refptr<ExtensionInstallPromptExperiment> experiment_;
+
+    DISALLOW_COPY_AND_ASSIGN(Prompt);
   };
 
   static const int kMinExtensionRating = 0;
   static const int kMaxExtensionRating = 5;
 
   class Delegate {
    public:
     // We call this method to signal that the installation should continue.
     virtual void InstallUIProceed() = 0;
 
@@ skipping 16 matching lines @@
     content::WebContents* parent_web_contents;
 
     // NativeWindow parent and navigator. If initialized using a parent web
     // contents, these are derived from it.
     gfx::NativeWindow parent_window;
     content::PageNavigator* navigator;
   };
 
   typedef base::Callback<void(const ExtensionInstallPrompt::ShowParams&,
                               ExtensionInstallPrompt::Delegate*,
-                              const ExtensionInstallPrompt::Prompt&)>
+                              scoped_refptr<ExtensionInstallPrompt::Prompt>)>
       ShowDialogCallback;
 
   // Callback to show the default extension install dialog.
   // The implementations of this function are platform-specific.
   static ShowDialogCallback GetDefaultShowDialogCallback();
 
   // Creates a dummy extension from the |manifest|, replacing the name and
   // description with the localizations if provided.
   static scoped_refptr<extensions::Extension> GetLocalizedExtensionForDisplay(
       const base::DictionaryValue* manifest,
@@ skipping 27 matching lines @@
       extensions::BundleInstaller* bundle,
       const extensions::PermissionSet* permissions);
 
   // This is called by the standalone installer to verify whether the install
   // from the webstore should proceed.
   //
   // We *MUST* eventually call either Proceed() or Abort() on |delegate|.
   virtual void ConfirmStandaloneInstall(Delegate* delegate,
                                         const extensions::Extension* extension,
                                         SkBitmap* icon,
-                                        const Prompt& prompt);
+                                        scoped_refptr<Prompt> prompt);
 
   // This is called by the installer to verify whether the installation from
   // the webstore should proceed. |show_dialog_callback| is optional and can be
   // NULL.
   //
   // We *MUST* eventually call either Proceed() or Abort() on |delegate|.
   virtual void ConfirmWebstoreInstall(
       Delegate* delegate,
       const extensions::Extension* extension,
       const SkBitmap* icon,
@@ skipping 16 matching lines @@
                                const extensions::Extension* extension);
 
   // This is called by the external install alert UI to verify whether the
   // extension should be enabled (external extensions are installed disabled).
   //
   // We *MUST* eventually call either Proceed() or Abort() on |delegate|.
   virtual void ConfirmExternalInstall(
       Delegate* delegate,
       const extensions::Extension* extension,
       const ShowDialogCallback& show_dialog_callback,
-      const Prompt& prompt);
+      scoped_refptr<Prompt> prompt);
 
   // This is called by the extension permissions API to verify whether an
   // extension may be granted additional permissions.
   //
   // We *MUST* eventually call either Proceed() or Abort() on |delegate|.
   virtual void ConfirmPermissions(Delegate* delegate,
                                   const extensions::Extension* extension,
                                   const extensions::PermissionSet* permissions);
 
   // This is called by the app handler launcher to review what permissions the
@@ skipping 55 matching lines @@
   // The object responsible for doing the UI specific actions.
   scoped_ptr<ExtensionInstallUI> install_ui_;
 
   // Parameters to show the confirmation UI.
   ShowParams show_params_;
 
   // The delegate we will call Proceed/Abort on after confirmation UI.
   Delegate* delegate_;
 
   // A pre-filled prompt.
-  Prompt prompt_;
+  scoped_refptr<Prompt> prompt_;
 
   // Used to show the confirm dialog.
   ShowDialogCallback show_dialog_callback_;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_