Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: master/skia_master_scripts/factory.py

Issue 313203003: on CompareGMs failure, show link to most recent results on this builder (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: now displayed as a clickable link next to buildstep name Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | master/skia_master_scripts/skia_build_step.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: master/skia_master_scripts/factory.py
diff --git a/master/skia_master_scripts/factory.py b/master/skia_master_scripts/factory.py
index 19d0f327aaa40f08c2c318c89cad5faa6c710308..97ae2a2c959874adc771903b407aff3509251c69 100644
--- a/master/skia_master_scripts/factory.py
+++ b/master/skia_master_scripts/factory.py
@@ -21,6 +21,7 @@ import config_private
import ntpath
import os
import posixpath
+import skia_vars
import utils
@@ -531,6 +532,10 @@ class SkiaFactory(BuildFactory):
"""Compare the actually-generated GM images to the checked-in baselines."""
self.AddSlaveScript(script='compare_gms.py',
description='CompareGMs',
+ get_props_from_stdout={
+ 'latest_gm_failures_url':
+ '%s([^\n]*)\n' % skia_vars.GetGlobalVariable(
+ 'latest_gm_failures_preamble')},
is_rebaseline_step=True)
def CompareRenderedSKPs(self):
« no previous file with comments | « no previous file | master/skia_master_scripts/skia_build_step.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698