Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: slave/skia_slave_scripts/compare_gms.py

Issue 313203003: on CompareGMs failure, show link to most recent results on this builder (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: slave/skia_slave_scripts/compare_gms.py
diff --git a/slave/skia_slave_scripts/compare_gms.py b/slave/skia_slave_scripts/compare_gms.py
index 90804deda6619e90ad1b15c608d7dffdce2b34eb..691bf12d3dd77ed7b23e974632fc67f7fc865184 100644
--- a/slave/skia_slave_scripts/compare_gms.py
+++ b/slave/skia_slave_scripts/compare_gms.py
@@ -13,6 +13,12 @@ from build_step import BuildStep, BuildStepWarning
from utils import misc
import run_gm
+LIVE_REBASELINE_SERVER_BASEURL = (
+ 'http://skia-tree-status.appspot.com/redirect/rebaseline-server/'
+ 'static/view.html#/view.html')
+# EPOGER: how can I share this definition with factory.py?
+LATEST_GM_FAILURES_PREAMBLE = 'View latest GM failures for this builder at: '
+
class CompareGMs(BuildStep):
def _Run(self):
json_summary_path = misc.GetAbsPath(os.path.join(
@@ -24,7 +30,11 @@ class CompareGMs(BuildStep):
# This import must happen after BuildStep.__init__ because it requires that
# CWD is in PYTHONPATH, and BuildStep.__init__ may change the CWD.
from gm import display_json_results
- if not display_json_results.Display(json_summary_path):
+ success = display_json_results.Display(json_summary_path)
+ print '%s%s?resultsToLoad=/results/failures&builder=%s' % (
+ LATEST_GM_FAILURES_PREAMBLE, LIVE_REBASELINE_SERVER_BASEURL,
+ self._builder_name)
+ if not success:
if self._builder_name in may_fail_with_warning:
raise BuildStepWarning('Expectations mismatch in %s!' %
json_summary_path)

Powered by Google App Engine
This is Rietveld 408576698