Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: Source/core/dom/Document.cpp

Issue 313183004: The element under mouse should be in hover state even if its not inActiveChain. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/css/hover-active-drag-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index b69cf2e04871d5bcbfef8fe95af8bd0c5ba78658..dd773c4461a2bde75cfd3ea1f12b3700dd91410f 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -5478,14 +5478,14 @@ void Document::updateHoverActiveState(const HitTestRequest& request, Element* in
// The old hover path only needs to be cleared up to (and not including) the common ancestor;
for (RenderObject* curr = oldHoverObj; curr && curr != ancestor; curr = curr->hoverAncestor()) {
- if (curr->node() && !curr->isText() && (!mustBeInActiveChain || curr->node()->inActiveChain()))
+ if (curr->node() && !curr->isText() && (!mustBeInActiveChain || curr->node()->inActiveChain() || curr == oldHoverObj))
Rick Byers 2014/06/12 18:24:06 This doesn't look like the right fix to me. How d
nodesToRemoveFromChain.append(curr->node());
}
}
// Now set the hover state for our new object up to the root.
for (RenderObject* curr = newHoverObj; curr; curr = curr->hoverAncestor()) {
- if (curr->node() && !curr->isText() && (!mustBeInActiveChain || curr->node()->inActiveChain()))
+ if (curr->node() && !curr->isText() && (!mustBeInActiveChain || curr->node()->inActiveChain() || curr == newHoverObj))
nodesToAddToChain.append(curr->node());
}
« no previous file with comments | « LayoutTests/fast/css/hover-active-drag-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698