Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 313173009: WebPrivatePtr: avoid creating temporary Persistent<> on assignment. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

WebPrivatePtr: avoid creating temporary Persistent<> on assignment. For RefCountedGarbageCollected objects wrapped in a WebPrivatePtr, the PtrStorageImpl::assign(PassRefPtr<T>) overload potentially created a Persistent on assigning its underlying raw pointer, even if a RawPtr<> was passed along (due to the implicit RawPtr<T> conversion that PassRefPtr<T> provides.) This assign() overload serves no real purpose with Oilpan enabled; provide a more appropriate RawPtr<T> version there. R=haraken@chromium.org,tkent@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175558

Patch Set 1 #

Patch Set 2 : Add #ifdef #

Patch Set 3 : Use a transition type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M public/platform/WebPrivatePtr.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
sof
Please take a look.
6 years, 6 months ago (2014-06-05 07:54:54 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-05 07:58:35 UTC) #2
tkent
lgtm
6 years, 6 months ago (2014-06-05 08:00:00 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-05 08:05:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/313173009/40001
6 years, 6 months ago (2014-06-05 08:06:18 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-05 09:15:37 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 10:12:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10406)
6 years, 6 months ago (2014-06-05 10:12:26 UTC) #8
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-05 10:35:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/313173009/40001
6 years, 6 months ago (2014-06-05 10:36:19 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 11:28:37 UTC) #11
Message was sent while issue was closed.
Change committed as 175558

Powered by Google App Engine
This is Rietveld 408576698