Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 313173008: Allow load if play() is immediately called when preload == 'none' (Closed)

Created:
6 years, 6 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 6 months ago
Reviewers:
adamk
CC:
blink-reviews, blink-reviews-html_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Allow load if play() is immediately called when preload == 'none' This fixes a bug where the load gets blocked by preload == 'none' eventhough JavaScript has called play() after setting the src attribute. This particular bug only appears if play() is called before the JavaScript code relinquishes control back to the UA. Tests cases were added to make sure that immediate load() and play() calls both trigger loading. Before this change, only immediate load() calls ignored the preload == "none" state. BUG=177870 TEST=LayoutTest/media/video-preload.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175590

Patch Set 1 #

Patch Set 2 : Rebase and remove trailing whitespace #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -14 lines) Patch
M LayoutTests/media/video-preload.html View 1 4 chunks +37 lines, -12 lines 0 comments Download
M LayoutTests/media/video-preload-expected.txt View 3 chunks +20 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
acolwell GONE FROM CHROMIUM
6 years, 6 months ago (2014-06-05 01:00:05 UTC) #1
adamk
lgtm
6 years, 6 months ago (2014-06-05 17:23:49 UTC) #2
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 6 months ago (2014-06-05 17:34:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/313173008/20001
6 years, 6 months ago (2014-06-05 17:35:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-05 18:11:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 18:14:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7058)
6 years, 6 months ago (2014-06-05 18:14:31 UTC) #7
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 6 months ago (2014-06-05 18:30:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/313173008/40001
6 years, 6 months ago (2014-06-05 18:32:06 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-05 20:08:52 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 20:11:35 UTC) #11
Message was sent while issue was closed.
Change committed as 175590

Powered by Google App Engine
This is Rietveld 408576698