Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 313173003: Revert of Resubmit: Refactor external_install_ui (Closed)

Created:
6 years, 6 months ago by Devlin
Modified:
6 years, 6 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Revert of Resubmit: Refactor external_install_ui (https://codereview.chromium.org/309643007/) Reason for revert: Led to increased crashiness: https://code.google.com/p/chromium/issues/detail?id=368809 Original issue's description: > Resubmit: Refactor external_install_ui > > Original CL: https://codereview.chromium.org/300853008/ > Original Description: > Refactors ExternalInstallUI to have determinate lifetimes. > This is likely the first of multiple patches targeting this area of code; the > next one will concentrate on pulling the related logic out of ExtensionService. > > ---------------------------------------------------- > > The original patch contained a cycle in that when an external install warning > was clicked, it would accept or remove the extension, and then remove the error. > Since the manager listened for the extension to be loaded or unloaded, this > resulted in a double-removal. Fix is straightforward. > > We also didn't have tests for actually interacting with the dialog, so two have > been added. > > TBR=yoz@chromium.org > BUG=378042 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274325 TBR=yoz@chromium.org NOTREECHECKS=true NOTRY=true BUG=378042 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274890

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+646 lines, -828 lines) Patch
M chrome/browser/extensions/extension_service.h View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 10 chunks +18 lines, -110 lines 0 comments Download
D chrome/browser/extensions/external_install_error.h View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/extensions/external_install_error.cc View 1 chunk +0 lines, -392 lines 0 comments Download
D chrome/browser/extensions/external_install_manager.h View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/extensions/external_install_manager.cc View 1 chunk +0 lines, -102 lines 0 comments Download
A chrome/browser/extensions/external_install_ui.h View 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/extensions/external_install_ui.cc View 1 chunk +590 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Devlin
Created Revert of Resubmit: Refactor external_install_ui
6 years, 6 months ago (2014-06-04 20:04:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/313173003/1
6 years, 6 months ago (2014-06-04 20:05:30 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 20:07:27 UTC) #3
Message was sent while issue was closed.
Change committed as 274890

Powered by Google App Engine
This is Rietveld 408576698