Android: Eliminate sync_file_system extensions code.

Android: Eliminate sync_file_system extensions code.

BUG=305852
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281667

[Lei Zhang, 2014-06-05 01:10:02]

The c/b/sync_file_system code is not used on mobile, right?

[tzik, 2014-06-05 03:42:03]

https://codereview.chromium.org/313123003/diff/20001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (left):

https://codereview.chromium.org/313123003/diff/20001/chrome/chrome_browser.gy...
chrome/chrome_browser.gypi:2615: 'sync_file_system_proto',
Doesn't this exclude sync_file_system*_proto also on desktop platforms?

[tzik, 2014-06-05 03:42:40]

On 2014/06/05 01:10:02, Lei Zhang wrote:
> The c/b/sync_file_system code is not used on mobile, right?

Right. It's desktop chrome only.

[Lei Zhang, 2014-06-05 05:48:01]

https://codereview.chromium.org/313123003/diff/20001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (left):

https://codereview.chromium.org/313123003/diff/20001/chrome/chrome_browser.gy...
chrome/chrome_browser.gypi:2615: 'sync_file_system_proto',
On 2014/06/05 03:42:04, tzik wrote:
> Doesn't this exclude sync_file_system*_proto also on desktop platforms?

Yes, I will undo this.

[Lei Zhang, 2014-06-05 05:52:27]

PTAL at patch set 2. This shaves ~230KB from chrome_shell.apk.

[tzik, 2014-06-05 07:05:32]

lgtm

[Lei Zhang, 2014-06-05 21:20:37]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-05 21:23:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/313123003/50001

[commit-bot: I haz the power, 2014-06-06 02:20:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-06 03:34:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 03:34:54]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[Lei Zhang, 2014-06-06 06:25:53]

https://chromiumcodereview.appspot.com/13357004 make it sound like
sync_file_system is used on mobile? I'm not familiar with
chrome/browser/browsing_data. Michael, do you have any knowledge of this?

[Lei Zhang, 2014-07-03 08:32:45]

On 2014/06/06 06:25:53, Lei Zhang wrote:
> https://chromiumcodereview.appspot.com/13357004 make it sound like
> sync_file_system is used on mobile? I'm not familiar with
> chrome/browser/browsing_data. Michael, do you have any knowledge of this?

... I built a Chrome APK with this change and bug 180249 did not reappear.

[Lei Zhang, 2014-07-03 08:32:49]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-03 08:34:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/313123003/80001

[Lei Zhang, 2014-07-03 10:23:27]

The CQ bit was unchecked by thestig@chromium.org

[Lei Zhang, 2014-07-08 01:50:54]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-08 01:52:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/313123003/100001

[commit-bot: I haz the power, 2014-07-08 04:17:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)

[commit-bot: I haz the power, 2014-07-08 05:05:15]

Change committed as 281667