Support GCF as the default HTML viewer. I simply extended the IsOptInUrl che...

Support GCF as the default HTML viewer as well as supporting an exclusion list.

Now, there are two URL lists that we support and a master REG_DWORD value ("IsDefaultRenderer" ) to switch between them.
Note that the OptInUrls key is no longer supported but the URL lists mentioned below function in the same way OptInUrls used to.

This is basically how it works:

if IsDefaultRenderer
  Url list name is "RenderInHostUrls" and lists patterns that the host (IE) should render.

if not IsDefaultRenderer  (i.e. it's 0)
  Url list name is "RenderInGcfUrls" and lists patterns that GCF should render.


Also fixing typo :)

TEST=See description above and in bug report.
BUG=50788
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55664

[amit, 2010-08-10 17:58:31]

LGTM

Looks pretty good. Now, as a next step, Chrome UA if the OptOut mode is set?

http://codereview.chromium.org/3131003/diff/1/4
File chrome_frame/utils.cc (right):

http://codereview.chromium.org/3131003/diff/1/4#newcode713
chrome_frame/utils.cc:713: bool ret = false;
nit: a better name? maybe something like load_in_chrome_frame.

http://codereview.chromium.org/3131003/diff/1/4#newcode718
chrome_frame/utils.cc:718: if
(config_key.ReadValueDW(kEnableGCFRendererByDefault,
nit: it might be faster/cleaner to check for OptIn or OptOut first as OptOut
mode will effectively override any OptIn URLs

Also, GetConfigBool would be useful here?

[tommi, 2010-08-10 18:16:11]

On 2010/08/10 17:58:31, amit wrote:
> LGTM
> 
> Looks pretty good. Now, as a next step, Chrome UA if the OptOut mode is set?
> 
> http://codereview.chromium.org/3131003/diff/1/4
> File chrome_frame/utils.cc (right):
> 
> http://codereview.chromium.org/3131003/diff/1/4#newcode713
> chrome_frame/utils.cc:713: bool ret = false;
> nit: a better name? maybe something like load_in_chrome_frame.
done.
> 
> http://codereview.chromium.org/3131003/diff/1/4#newcode718
> chrome_frame/utils.cc:718: if
> (config_key.ReadValueDW(kEnableGCFRendererByDefault,
> nit: it might be faster/cleaner to check for OptIn or OptOut first 

uhm, I'm confused.  Which one should I check first?

> as OptOut mode will effectively override any OptIn URLs
> 
> Also, GetConfigBool would be useful here?

I figured I'd use the config key I've already got instead of opening a new one.

[tommi, 2010-08-10 19:02:32]

new changes uploaded.

[amit, 2010-08-10 20:36:24]

lgtm

http://codereview.chromium.org/3131003/diff/6003/11003
File chrome_frame/utils.cc (right):

http://codereview.chromium.org/3131003/diff/6003/11003#newcode730
chrome_frame/utils.cc:730: load_in_chrome_frame = !load_in_chrome_frame;
true! :)
We definitely need a unit test for this. This function does not look very
friendly to that idea in its current form, so it's OK to do it in a subsequent
patch.