runtime/vm/flow_graph_compiler_x64.cc - Issue 313083008: Add LoadTaggedClassIdMayBeSmi to assembly and improve performance of inline cache stubs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 313083008: Add LoadTaggedClassIdMayBeSmi to assembly and improve performance of inline cache stubs. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_x64.cc

===================================================================

--- runtime/vm/flow_graph_compiler_x64.cc (revision 37007)

+++ runtime/vm/flow_graph_compiler_x64.cc (working copy)

@@ -1317,19 +1317,10 @@

ASSERT(!arguments_descriptor.IsNull() && (arguments_descriptor.Length() > 0));

const MegamorphicCache& cache =

MegamorphicCache::ZoneHandle(table->Lookup(name, arguments_descriptor));

- Label not_smi, load_cache;

__ movq(RAX, Address(RSP, (argument_count - 1) * kWordSize));

- __ testq(RAX, Immediate(kSmiTagMask));

- __ j(NOT_ZERO, &not_smi, Assembler::kNearJump);

- __ LoadImmediate(RAX, Immediate(Smi::RawValue(kSmiCid)), PP);

- __ jmp(&load_cache);

+ __ LoadTaggedClassIdMayBeSmi(RAX, RAX);

- __ Bind(&not_smi);

- __ LoadClassId(RAX, RAX);

- __ SmiTag(RAX);

// RAX: class ID of the receiver (smi).

- __ Bind(&load_cache);

__ LoadObject(RBX, cache, PP);

__ movq(RDI, FieldAddress(RBX, MegamorphicCache::buckets_offset()));

__ movq(RBX, FieldAddress(RBX, MegamorphicCache::mask_offset()));

« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »