Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: runtime/vm/assembler_arm64.cc

Issue 313083008: Add LoadTaggedClassIdMayBeSmi to assembly and improve performance of inline cache stubs. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_arm64.cc
===================================================================
--- runtime/vm/assembler_arm64.cc (revision 36956)
+++ runtime/vm/assembler_arm64.cc (working copy)
@@ -1073,6 +1073,19 @@
}
+void Assembler::LoadTaggedClassIdMayBeSmi(Register result, Register object) {
zra 2014/06/04 18:55:00 tsti(object, kSmiTagMask); LoadImmediate(result, S
srdjan 2014/06/04 20:08:04 Discussed offline, leave it as it be since LoadCla
+ Label load, done;
+ tsti(object, kSmiTagMask);
+ b(&load, NE);
+ LoadImmediate(result, Smi::RawValue(kSmiCid), PP);
+ b(&done);
+ Bind(&load);
+ LoadClassId(result, object, PP);
+ SmiTag(result);
+ Bind(&done);
+}
+
+
// Frame entry and exit.
void Assembler::ReserveAlignedFrameSpace(intptr_t frame_space) {
// Reserve space for arguments and align frame before entering

Powered by Google App Engine
This is Rietveld 408576698