Use FSEvents for recursive file watch on Mac

base/files/file_path_watcher_mac.cc

Index: base/files/file_path_watcher_mac.cc
diff --git a/base/files/file_path_watcher_mac.cc b/base/files/file_path_watcher_mac.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a63b8a49603493ba1cfe96ab0f023d3dbce452d6
--- /dev/null
+++ b/base/files/file_path_watcher_mac.cc
@@ -0,0 +1,64 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/files/file_path_watcher.h"
+#include "base/files/file_path_watcher_kqueue.h"
+
+#if !defined(OS_IOS)
+#include "base/files/file_path_watcher_fsevents.h"
+#include "base/mac/mac_util.h"
+#endif
+
+namespace base {
+
+namespace {
+
+class FilePathWatcherImpl : public FilePathWatcher::PlatformDelegate {
+ public:
+  virtual bool Watch(const FilePath& path,
+                     bool recursive,
+                     const FilePathWatcher::Callback& callback) OVERRIDE {
+    // Use kqueue for non-recursive watches and FSEvents for recursive ones.
+    DCHECK(!impl_.get());
+    if (recursive) {
+      // FSEvents isn't available on iOS and is broken on OSX 10.6 and earlier.
+      // See http://crbug.com/54822#c31
+#if !defined(OS_IOS)

[Mark Mentovai, 2014/06/08 15:29:02]

file_path_watcher_browsertest has a function RecursiveWatchAvaiable that
basically duplicates this logic. Probably instead, FilePathWatcherFSEvents
should have a static bool function that does this, even on iOS. An inline in the
header is OK.

[vandebo (ex-Chrome), 2014/06/10 00:52:06]

The fsevents header needs some stuff not available on IOS, so I moved the
function into the main file_path_watcher files.

+      if (mac::IsOSLionOrLater())
+        impl_ = new FilePathWatcherFSEvents();
+#endif  // OS_IOS
+
+      if (!impl_)
+        return false;
+    } else {
+      impl_ = new FilePathWatcherKQueue();
+    }
+    return impl_->Watch(path, recursive, callback);
+  }
+
+  virtual void Cancel() OVERRIDE {
+    if (impl_)
+      impl_->Cancel();
+    set_cancelled();
+  }
+
+  virtual void CancelOnMessageLoopThread() OVERRIDE {
+    if (impl_)
+      impl_->Cancel();
+    set_cancelled();
+  }
+
+ protected:
+  virtual ~FilePathWatcherImpl() {}
+
+  scoped_refptr<PlatformDelegate> impl_;
+};
+
+}  // namespace
+
+FilePathWatcher::FilePathWatcher() {
+  impl_ = new FilePathWatcherImpl();
+}
+
+}  // namespace base