Issue 313083006: Rename ReverseCondition to CommuteCondition, a more standard term.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 313083006: Rename ReverseCondition to CommuteCondition, a more standard term. (Closed)

Created:
6 years, 6 months ago by titzer

Modified:
6 years, 6 months ago

Reviewers:
dcarney, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Rename ReverseCondition to CommuteCondition, a more standard term. R=dcarney@chromium.org, dcarney BUG= Committed: https://code.google.com/p/v8/source/detail?r=21677

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -33 lines)			Patch
M	src/arm/constants-arm.h	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	src/arm/lithium-codegen-arm.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/arm64/constants-arm64.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	src/ia32/assembler-ia32.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/mips/constants-mips.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/assembler-x64.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x87/assembler-x87.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x87/lithium-codegen-x87.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

titzer

Committed patchset #1 manually as r21677 (presubmit successful).

6 years, 6 months ago (2014-06-04 14:58:05 UTC) #3

Jakob Kummerow

6 years, 6 months ago (2014-06-04 18:04:54 UTC) #4

Message was sent while issue was closed.

DBC (applies to all platforms).

https://codereview.chromium.org/313083006/diff/1/src/arm/constants-arm.h
File src/arm/constants-arm.h (right):

https://codereview.chromium.org/313083006/diff/1/src/arm/constants-arm.h#newc...
src/arm/constants-arm.h:92: // Commute a condition such that a cond b == b cond'
b.
Where by "b", you mean "a", right? :-P

Expand Messages | Collapse Messages