DevTools: Show rules from imported stylesheets.

DevTools: Show rules from imported stylesheets.

BUG=378778
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175668

[vsevik, 2014-06-04 13:59:21]

Test to follow

[vsevik, 2014-06-05 09:34:14]

PTAL

[lushnikov, 2014-06-06 09:04:34]

On 2014/06/05 09:34:14, vsevik wrote:
> PTAL

documentStyleSheetCollection()->activeAuthorStyleSheets() is a subset of
documentStyleSheetCollection()->styleSheetsForStyleSheetList(). How come we get
missing imported stylesheet on frontend?

[vsevik, 2014-06-06 11:40:26]

> documentStyleSheetCollection()->activeAuthorStyleSheets() is a subset of
> documentStyleSheetCollection()->styleSheetsForStyleSheetList().
Well, it is not.

documentStyleSheetCollection()->styleSheetsForStyleSheetList() contains all the
stylesheets linked from this document.
However, documentStyleSheetCollection()->activeAuthorStyleSheets() of the main
document contains all the active stylesheets including imported ones (this list
is actually used for rendering).
Meanwhille documentStyleSheetCollection()->activeAuthorStyleSheets() of the
imported document is afaict empty.


Here is a list of places in the code where these lists are actually filled:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[lushnikov, 2014-06-06 12:32:57]

On 2014/06/06 11:40:26, vsevik wrote:
> > documentStyleSheetCollection()->activeAuthorStyleSheets() is a subset of
> > documentStyleSheetCollection()->styleSheetsForStyleSheetList().
> Well, it is not.
> 
> documentStyleSheetCollection()->styleSheetsForStyleSheetList() contains all
the
> stylesheets linked from this document.
> However, documentStyleSheetCollection()->activeAuthorStyleSheets() of the main
> document contains all the active stylesheets including imported ones (this
list
> is actually used for rendering).
> Meanwhille documentStyleSheetCollection()->activeAuthorStyleSheets() of the
> imported document is afaict empty.
> 
> 
> Here is a list of places in the code where these lists are actually filled:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

wow.
lgtm.

[lushnikov, 2014-06-06 12:33:02]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2014-06-06 12:33:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vsevik@chromium.org/313083005/20001

[commit-bot: I haz the power, 2014-06-06 14:03:29]

Change committed as 175668