Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 313053008: Remove some code now that forceCompositingMode is gone. (Closed)

Created:
6 years, 6 months ago by ojan
Modified:
6 years, 6 months ago
Reviewers:
Ian Vollick, esprehn
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Visibility:
Public.

Description

Remove some code now that forceCompositingMode is gone. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175531

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 2 chunks +2 lines, -11 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
ojan
https://codereview.chromium.org/313053008/diff/1/Source/core/rendering/compositing/RenderLayerCompositor.cpp File Source/core/rendering/compositing/RenderLayerCompositor.cpp (left): https://codereview.chromium.org/313053008/diff/1/Source/core/rendering/compositing/RenderLayerCompositor.cpp#oldcode232 Source/core/rendering/compositing/RenderLayerCompositor.cpp:232: if (staleInCompositingMode()) Honestly, I can't remember why this was ...
6 years, 6 months ago (2014-06-05 03:32:21 UTC) #1
Ian Vollick
On 2014/06/05 03:32:21, ojan wrote: > https://codereview.chromium.org/313053008/diff/1/Source/core/rendering/compositing/RenderLayerCompositor.cpp > File Source/core/rendering/compositing/RenderLayerCompositor.cpp (left): > > https://codereview.chromium.org/313053008/diff/1/Source/core/rendering/compositing/RenderLayerCompositor.cpp#oldcode232 > ...
6 years, 6 months ago (2014-06-05 03:47:56 UTC) #2
Ian Vollick
The CQ bit was checked by vollick@chromium.org
6 years, 6 months ago (2014-06-05 03:48:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/313053008/1
6 years, 6 months ago (2014-06-05 03:49:02 UTC) #4
esprehn
lgtm
6 years, 6 months ago (2014-06-05 04:38:53 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 05:05:56 UTC) #6
Message was sent while issue was closed. 
Change committed as 175531

Powered by Google App Engine
This is Rietveld 408576698