Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2438)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

Issue 313053007: Passing BackgroundColorSpan and UnderlineSpan from Clank to Blink. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Making AppendBackgroundColorSpan() static; handling UnderlineSpan. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java
index f2ae82906223fa1bbd9e267a65018cf07fdfa879..24ad6d26f4397445e8f896414b7acf6c6caadcdc 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java
@@ -19,6 +19,8 @@ import android.view.inputmethod.ExtractedTextRequest;
import com.google.common.annotations.VisibleForTesting;
+import java.lang.CharSequence;
aurimas (slooooooooow) 2014/06/10 18:36:18 Is this import needed?
huangs 2014/06/10 19:54:53 Not needed to compile, but I lapsed into "include
+
/**
* InputConnection is created by ContentView.onCreateInputConnection.
* It then adapts android's IME to chrome's RenderWidgetHostView using the
@@ -216,8 +218,7 @@ public class AdapterInputConnection extends BaseInputConnection {
if (maybePerformEmptyCompositionWorkaround(text)) return true;
super.setComposingText(text, newCursorPosition);
updateSelectionIfRequired();
- return mImeAdapter.checkCompositionQueueAndCallNative(text.toString(),
- newCursorPosition, false);
+ return mImeAdapter.checkCompositionQueueAndCallNative(text, newCursorPosition, false);
}
/**
@@ -229,8 +230,8 @@ public class AdapterInputConnection extends BaseInputConnection {
if (maybePerformEmptyCompositionWorkaround(text)) return true;
super.commitText(text, newCursorPosition);
updateSelectionIfRequired();
- return mImeAdapter.checkCompositionQueueAndCallNative(text.toString(),
- newCursorPosition, text.length() > 0);
+ return mImeAdapter.checkCompositionQueueAndCallNative(text, newCursorPosition,
+ text.length() > 0);
}
/**

Powered by Google App Engine
This is Rietveld 408576698