content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 313053007: Passing BackgroundColorSpan and UnderlineSpan from Clank to Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 313053007: Passing BackgroundColorSpan and UnderlineSpan from Clank to Blink. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Making AppendBackgroundColorSpan() static; handling UnderlineSpan. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index 6bec9f27ccacfd082660b5bf1708b6b7df56c727..32b666fbadbe0a9d0f21905c620cbbaa15254492 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -1357,7 +1357,8 @@ void RenderWidgetHostViewAura::SetCompositionText(

underlines.push_back(blink::WebCompositionUnderline(it->start_offset,

it->end_offset,

it->color,

- it->thick));

+ it->thick,

+ it->background_color));

}

// TODO(suzhe): due to a bug of webkit, we can't use selection range with