content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java - Issue 313053007: Passing BackgroundColorSpan and UnderlineSpan from Clank to Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

Issue 313053007: Passing BackgroundColorSpan and UnderlineSpan from Clank to Blink. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Replacing direct JNI calls with JNI generator, and calling back to Java to dispatch. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/ime_adapter_android.h ('K') | « content/common/content_param_traits_macros.h ('k') | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

index f2ae82906223fa1bbd9e267a65018cf07fdfa879..24ad6d26f4397445e8f896414b7acf6c6caadcdc 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

@@ -19,6 +19,8 @@ import android.view.inputmethod.ExtractedTextRequest;

import com.google.common.annotations.VisibleForTesting;

+import java.lang.CharSequence;

/**

* InputConnection is created by ContentView.onCreateInputConnection.

* It then adapts android's IME to chrome's RenderWidgetHostView using the

@@ -216,8 +218,7 @@ public class AdapterInputConnection extends BaseInputConnection {

if (maybePerformEmptyCompositionWorkaround(text)) return true;

super.setComposingText(text, newCursorPosition);

updateSelectionIfRequired();

- return mImeAdapter.checkCompositionQueueAndCallNative(text.toString(),

- newCursorPosition, false);

+ return mImeAdapter.checkCompositionQueueAndCallNative(text, newCursorPosition, false);

}

/**

@@ -229,8 +230,8 @@ public class AdapterInputConnection extends BaseInputConnection {

if (maybePerformEmptyCompositionWorkaround(text)) return true;

super.commitText(text, newCursorPosition);

updateSelectionIfRequired();

- return mImeAdapter.checkCompositionQueueAndCallNative(text.toString(),

- newCursorPosition, text.length() > 0);

+ return mImeAdapter.checkCompositionQueueAndCallNative(text, newCursorPosition,

+ text.length() > 0);

}

/**