Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 313043002: Notify DevTools about cached resources when stylesheet is restored. (Closed)

Created:
6 years, 6 months ago by eustas
Modified:
6 years, 6 months ago
Reviewers:
Nate Chapin, tasak
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Notify DevTools about cached resources when stylesheet is restored. BUG=337065 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175640

Patch Set 1 #

Total comments: 2

Patch Set 2 : Call notifyLoadedFromCache from requestLoadStarted #

Patch Set 3 : Polish #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/core/fetch/ResourceFetcher.cpp View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
eustas
6 years, 6 months ago (2014-06-04 05:57:30 UTC) #1
tasak
lgtm
6 years, 6 months ago (2014-06-04 09:13:22 UTC) #2
Nate Chapin
https://codereview.chromium.org/313043002/diff/1/Source/core/css/CSSFontFaceSrcValue.cpp File Source/core/css/CSSFontFaceSrcValue.cpp (right): https://codereview.chromium.org/313043002/diff/1/Source/core/css/CSSFontFaceSrcValue.cpp#newcode127 Source/core/css/CSSFontFaceSrcValue.cpp:127: document->fetcher()->notifyLoadedFromMemoryCache(m_fetched.get()); Why not call this in requestLoadStarted() instad of ...
6 years, 6 months ago (2014-06-04 16:03:37 UTC) #3
eustas
https://codereview.chromium.org/313043002/diff/1/Source/core/css/CSSFontFaceSrcValue.cpp File Source/core/css/CSSFontFaceSrcValue.cpp (right): https://codereview.chromium.org/313043002/diff/1/Source/core/css/CSSFontFaceSrcValue.cpp#newcode127 Source/core/css/CSSFontFaceSrcValue.cpp:127: document->fetcher()->notifyLoadedFromMemoryCache(m_fetched.get()); On 2014/06/04 16:03:37, Nate Chapin wrote: > Why ...
6 years, 6 months ago (2014-06-05 07:32:20 UTC) #4
Nate Chapin
Thanks! LGTM
6 years, 6 months ago (2014-06-05 16:09:31 UTC) #5
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-06 04:39:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/313043002/40001
6 years, 6 months ago (2014-06-06 04:40:32 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-06 05:43:32 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 06:43:08 UTC) #9
Message was sent while issue was closed.
Change committed as 175640

Powered by Google App Engine
This is Rietveld 408576698