Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 313033003: Oilpan: Make ActiveParserSession::m_document traceable. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Visibility:
Public.

Description

Oilpan: Make ActiveParserSession::m_document traceable. ActiveParserSession, NestingLevelIncrementer, and PumpSession are allocatable only on stack. We can make m_document Member<> without trace(). BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/core/html/parser/HTMLParserScheduler.h View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/parser/NestingLevelIncrementer.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent
Please review this.
6 years, 6 months ago (2014-06-04 06:47:36 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-04 06:48:47 UTC) #2
zerny-chromium
lgtm
6 years, 6 months ago (2014-06-04 06:55:17 UTC) #3
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-04 08:07:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/313033003/1
6 years, 6 months ago (2014-06-04 08:08:22 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 09:03:24 UTC) #6
Message was sent while issue was closed.
Change committed as 175458

Powered by Google App Engine
This is Rietveld 408576698