Source/bindings/v8/V8NodeFilterCondition.cpp - Issue 313033002: Rethrow exception when swallowing it is not intended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8NodeFilterCondition.cpp

Issue 313033002: Rethrow exception when swallowing it is not intended. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/V8NodeFilterCondition.cpp

diff --git a/Source/bindings/v8/V8NodeFilterCondition.cpp b/Source/bindings/v8/V8NodeFilterCondition.cpp

index d8007c764733a6297614106a007f7e750e415a8b..5599e68bcd5f7e551d3c84c86a9723994204c01a 100644

--- a/Source/bindings/v8/V8NodeFilterCondition.cpp

+++ b/Source/bindings/v8/V8NodeFilterCondition.cpp

@@ -69,6 +69,7 @@ short V8NodeFilterCondition::acceptNode(Node* node, ExceptionState& exceptionSta

return NodeFilter::FILTER_ACCEPT;

v8::TryCatch exceptionCatcher;

+ V8RethrowTryCatchScope rethrow(exceptionCatcher);

v8::Handle<v8::Function> callback;

if (filter->IsFunction())

« Source/bindings/v8/V8BindingMacros.h ('K') | « Source/bindings/v8/V8BindingMacros.h ('k') | no next file » | no next file with comments »