Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: LayoutTests/fast/events/onchange-js.html

Issue 313013005: Set value of m_textAsOfLastFormControlChangeEvent before triggering change event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/events/onchange-js-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <p>This test verifies that the change event is fired, when value is changed in c hange event handler.</p>
2 <hr>
3 <input id="input" type="text" onchange="changeHandler()"></input>
keishi 2014/06/04 21:26:22 nit: input doesn't need end tag in html
Habib Virji 2014/06/05 08:43:23 Done.
4 <pre id="console"></pre>
5
6 <script>
7 function log(s)
8 {
9 document.getElementById('console').appendChild(document.createTextNode(s + " \n"));
10 }
11
12 function changeHandler()
13 {
14 log('change event fired');
keishi 2014/06/04 20:43:54 nit: inconsistent string literal quotes. You used
Habib Virji 2014/06/05 08:43:23 Done.
15 document.getElementById('input').value = ' ';
keishi 2014/06/04 21:26:22 nit: use input variable
16 }
17
18 if (window.testRunner)
19 testRunner.dumpAsText();
20
21 var input = document.getElementById('input');
22
23 input.focus();
24 document.execCommand("InsertText", false, "foo bar baz");
25 input.blur();
26
27 input.focus();
28 document.execCommand("InsertText", false, "foo bar baz");
keishi 2014/06/04 20:43:54 This test is not reproducing the bug. InsertText j
Habib Virji 2014/06/05 08:43:23 Not sure, what I am trying to do with test is put
keishi 2014/06/05 09:02:17 I tried this test on Chrome Canary and it passes s
Habib Virji 2014/06/05 09:33:31 Thanks Keishi, I have updated test to now check st
29 input.blur();
30
31 </script>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/fast/events/onchange-js-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698