Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: master.tryserver.webkit/master.cfg

Issue 313010: Revert many of the hacks that aren't necessary since we updated buildbot past 0.7.11. (Closed)
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: master.tryserver.webkit/master.cfg
diff --git a/master.tryserver.webkit/master.cfg b/master.tryserver.webkit/master.cfg
index 15e3cd115db54da567973ac15714b7ecbce40b28..4e7d15516e139f1368d8de02df456df846396236 100644
--- a/master.tryserver.webkit/master.cfg
+++ b/master.tryserver.webkit/master.cfg
@@ -16,9 +16,7 @@ from buildbot.changes.pb import PBChangeSource
from buildbot.scheduler import AnyBranchScheduler, Triggerable
from buildbot.status import html
from buildbot.process import buildstep, factory, properties
-# TODO(nsylvain) master is not available in 8.08.
-#from buildbot.steps import master, shell, source, transfer, trigger
-from buildbot.steps import shell, source, transfer, trigger
+from buildbot.steps import master, shell, source, transfer, trigger
from buildbot.status.builder import SUCCESS, FAILURE, WARNINGS, SKIPPED
from twisted.internet import defer
@@ -302,31 +300,31 @@ class UploadTestResults(transfer.FileUpload):
transfer.FileUpload.__init__(self, self.slavesrc, self.masterdest)
-# TODO(nsylvain): master is not available in 0.7.8
-#class ExtractTestResults(master.MasterShellCommand):
-# zipFile = WithProperties("public_html/results/%(buildername)s/r%(got_revision)s (%(buildnumber)s).zip")
-# resultDirectory = WithProperties("public_html/results/%(buildername)s/r%(got_revision)s (%(buildnumber)s)")
-#
-# def __init__(self):
-# master.MasterShellCommand.__init__(self, "")
-#
-# def start(self):
-# self.command = ["ditto", "-k", "-x", "-V", self.build.getProperties().render(self.zipFile), self.build.getProperties().render(self.resultDirectory)]
-# return master.MasterShellCommand.start(self)
-#
-# def finished(self, result):
-# url = self.build.getProperties().render(self.resultDirectory).replace("public_html/", "")
-# self.addURL("view results", url)
-# result = master.MasterShellCommand.finished(self, result)
-# self.step_status.setText(["uploaded results"])
-# return result
+class ExtractTestResults(master.MasterShellCommand):
+ zipFile = WithProperties("public_html/results/%(buildername)s/r%(got_revision)s (%(buildnumber)s).zip")
+ resultDirectory = WithProperties("public_html/results/%(buildername)s/r%(got_revision)s (%(buildnumber)s)")
+
+ def __init__(self):
+ master.MasterShellCommand.__init__(self, "")
+
+ def start(self):
+ self.command = ["ditto", "-k", "-x", "-V", self.build.getProperties().render(self.zipFile), self.build.getProperties().render(self.resultDirectory)]
+ return master.MasterShellCommand.start(self)
+
+ def finished(self, result):
+ url = self.build.getProperties().render(self.resultDirectory).replace("public_html/", "")
+ self.addURL("view results", url)
+ result = master.MasterShellCommand.finished(self, result)
+ self.step_status.setText(["uploaded results"])
+ return result
class Factory(factory.BuildFactory):
+ CheckOutClass = CheckOutSource
def __init__(self, platform, configuration, architectures, buildOnly):
factory.BuildFactory.__init__(self)
self.addStep(ConfigureBuild, platform=platform, configuration=configuration, architecture=" ".join(architectures), buildOnly=buildOnly)
- self.addStep(CheckOutSource)
+ self.addStep(self.CheckOutClass)
if platform == "win":
self.addStep(InstallWin32Dependencies)
@@ -356,8 +354,7 @@ class TestFactory(Factory):
self.addStep(RunWebKitTests, skipBuild=(platform == 'win'))
self.addStep(ArchiveTestResults)
self.addStep(UploadTestResults)
- # TODO(nsylvain): master is not available in 0.7.8
- #self.addStep(ExtractTestResults)
+ self.addStep(ExtractTestResults)
class BuildAndTestFactory(Factory):
TestClass = RunWebKitTests
@@ -368,16 +365,18 @@ class BuildAndTestFactory(Factory):
self.addStep(self.TestClass)
self.addStep(ArchiveTestResults)
self.addStep(UploadTestResults)
- # TODO(nsylvain): master is not available in 0.7.8
- #self.addStep(ExtractTestResults)
+ self.addStep(ExtractTestResults)
class BuildAndTestLeaksFactory(BuildAndTestFactory):
TestClass = RunWebKitLeakTests
+class TryJobCheckOutSource(CheckOutSource):
+ mode = "copy"
class TryFactory(Factory):
"""Similar to BuildAndTestFactory but doesn't archive the results."""
TestClass = RunWebKitTests
+ CheckOutClass = TryJobCheckOutSource
def __init__(self, platform, configuration, architectures):
Factory.__init__(self, platform, configuration, architectures, False)
self.addStep(CompileWebKit)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698