Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 313003005: [chromedriver] Pass --test-type=webdriver when launching Chrome (Closed)

Created:
6 years, 6 months ago by samuong
Modified:
6 years, 6 months ago
Reviewers:
stgao
CC:
chromium-reviews, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[chromedriver] Pass --test-type=webdriver when launching Chrome. This prevents Chrome from creating an infobar warning about unsupported flags (in particular --ignore-certificate-errors, which we also pass when launching Chrome). BUG=chromedriver:799 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
samuong
6 years, 6 months ago (2014-06-04 05:58:33 UTC) #1
stgao
lgtm
6 years, 6 months ago (2014-06-04 06:09:56 UTC) #2
samuong
The CQ bit was checked by samuong@chromium.org
6 years, 6 months ago (2014-06-04 15:29:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/313003005/1
6 years, 6 months ago (2014-06-04 15:31:52 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 21:34:53 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 21:39:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10570)
6 years, 6 months ago (2014-06-04 21:39:58 UTC) #7
samuong
The CQ bit was checked by samuong@chromium.org
6 years, 6 months ago (2014-06-05 00:50:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/313003005/1
6 years, 6 months ago (2014-06-05 00:51:41 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 02:37:04 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 02:44:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10764)
6 years, 6 months ago (2014-06-05 02:44:45 UTC) #12
samuong
The CQ bit was checked by samuong@chromium.org
6 years, 6 months ago (2014-06-06 01:17:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/313003005/1
6 years, 6 months ago (2014-06-06 01:20:53 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 01:42:10 UTC) #15
Message was sent while issue was closed.
Change committed as 275296

Powered by Google App Engine
This is Rietveld 408576698