Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/browser/extensions/settings_api_helpers.h

Issue 312943002: Remove unused param from search engine extension override helper function. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More functions Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/settings_api_helpers.h
diff --git a/chrome/browser/extensions/settings_api_helpers.h b/chrome/browser/extensions/settings_api_helpers.h
index db2ba36022a0ba95715c036f5336cfac6ef1e035..aaee468afe8464f6818eb367feb0b5b9631fdfa2 100644
--- a/chrome/browser/extensions/settings_api_helpers.h
+++ b/chrome/browser/extensions/settings_api_helpers.h
@@ -13,35 +13,19 @@ class BrowserContext;
namespace extensions {
-struct SettingsOverrides;
-
-// Find which |extension| is overriding a particular |type| of setting. Returns
-// the SettingsOverride object, or NULL if no |extension| is overriding that
-// particular setting.
-const extensions::SettingsOverrides* FindOverridingExtension(
- content::BrowserContext* browser_context,
- SettingsApiOverrideType type,
- const Extension** extension);
-
// Returns which extension is overriding the homepage in a given
-// |browser_context|. |home_page_url|, if non-NULL, will contain the home_page
-// value the extension has set.
-const Extension* OverridesHomepage(content::BrowserContext* browser_context,
- GURL* home_page_url);
+// |browser_context|.
Devlin 2014/06/03 23:55:10 nit: an "if any" in the comments may be in order t
+const Extension* OverridesHomepage(content::BrowserContext* browser_context);
Devlin 2014/06/03 23:55:10 Is the change to make these methods GetExtensionOv
Finnur 2014/06/04 00:13:09 Wow... that's weird. I remember writing that chang
Devlin 2014/06/04 15:05:57 The change was originally part of this patch: http
// Returns which extension is overriding the homepage in a given
-// |browser_context|. |startup_pages|, if non-NULL, will contain the vector of
-// startup page URLs the extension has set.
-const Extension* OverridesStartupPages(content::BrowserContext* browser_context,
- std::vector<GURL>* startup_pages);
+// |browser_context|.
+const Extension* OverridesStartupPages(
+ content::BrowserContext* browser_context);
// Returns which extension is overriding the search engine in a given
-// |browser_context|. |search_provider|, if non-NULL, will contain the search
-// provider the extension has set.
+// |browser_context|.
const Extension* OverridesSearchEngine(
- content::BrowserContext* browser_context,
- api::manifest_types::ChromeSettingsOverrides::Search_provider*
- search_provider);
+ content::BrowserContext* browser_context);
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698