Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

Issue 312943002: Remove unused param from search engine extension override helper function. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More functions Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h" 5 #include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/extensions/dev_mode_bubble_controller.h" 10 #include "chrome/browser/extensions/dev_mode_bubble_controller.h"
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 } 333 }
334 334
335 bool ExtensionMessageBubbleFactory::MaybeShowStartupOverrideExtensionsBubble( 335 bool ExtensionMessageBubbleFactory::MaybeShowStartupOverrideExtensionsBubble(
336 views::View* anchor_view) { 336 views::View* anchor_view) {
337 #if !defined(OS_WIN) 337 #if !defined(OS_WIN)
338 return false; 338 return false;
339 #endif 339 #endif
340 340
341 DCHECK(!shown_startup_override_extensions_bubble_); 341 DCHECK(!shown_startup_override_extensions_bubble_);
342 342
343 const Extension* extension = OverridesStartupPages(profile_, NULL); 343 const Extension* extension = OverridesStartupPages(profile_);
344 if (!extension) 344 if (!extension)
345 return false; 345 return false;
346 346
347 scoped_ptr<SettingsApiBubbleController> settings_api_bubble( 347 scoped_ptr<SettingsApiBubbleController> settings_api_bubble(
348 new SettingsApiBubbleController(profile_, 348 new SettingsApiBubbleController(profile_,
349 BUBBLE_TYPE_STARTUP_PAGES)); 349 BUBBLE_TYPE_STARTUP_PAGES));
350 if (!settings_api_bubble->ShouldShow(extension->id())) 350 if (!settings_api_bubble->ShouldShow(extension->id()))
351 return false; 351 return false;
352 352
353 shown_startup_override_extensions_bubble_ = true; 353 shown_startup_override_extensions_bubble_ = true;
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
470 } 470 }
471 471
472 void ExtensionMessageBubbleFactory::Finish() { 472 void ExtensionMessageBubbleFactory::Finish() {
473 MaybeStopObserving(); 473 MaybeStopObserving();
474 controller_.reset(); 474 controller_.reset();
475 anchor_view_ = NULL; 475 anchor_view_ = NULL;
476 container_ = NULL; 476 container_ = NULL;
477 } 477 }
478 478
479 } // namespace extensions 479 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698