Issue 3129007: FBTF: Forward declare everything possible in testing_profile.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3129007: FBTF: Forward declare everything possible in testing_profile.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Elliot Glaysher

Modified:
4 years ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, cbentzel+watch_chromium.org, idana, ben+cc_chromium.org, Raghu Simha, Erik does not do reviews, Paul Godavari, ncarter, Aaron Boodman, darin-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org, timsteele, John Grabowski

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

FBTF: Forward declare everything possible in testing_profile.h BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56053

Patch Set 1 #

Patch Set 2 : linux compile fixes #

Patch Set 3 : win fixes #

Patch Set 4 : mac compile fixes #

Patch Set 5 : Fix mac tests #

Patch Set 6 : merge fail #

Patch Set 7 : Fix MORE merge fail #

Patch Set 8 : argh mac problems now #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+240 lines, -105 lines)			Patch
M	chrome/browser/autocomplete/history_contents_provider_unittest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/browsing_data_database_helper_browsertest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/browsing_data_database_helper_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper_browsertest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.h	View	4	2 chunks	+4 lines, -13 lines	0 comments	Download
M	chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.mm	View	4	2 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_all_tabs_controller_unittest.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_controller_unittest.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_button_cell_unittest.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_button_unittest.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_editor_controller_unittest.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_folder_target_unittest.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bug_report_window_controller_unittest.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm	View	4 5 6 7	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/cookie_prompt_window_controller_unittest.mm	View	4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/edit_search_engine_cocoa_controller_unittest.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/content_setting_bubble_model_unittest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/cookies_tree_model_unittest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/download/download_manager_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/encoding_menu_controller_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_cookies_unittest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service_unittest.cc	View	1 2 3 4 5 6	4 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_exceptions_table_model_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_permission_context_unittest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_settings_state_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_bar_gtk_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/gtk/gtk_theme_provider_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/gtk/keyword_editor_view_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/gtk/options/languages_page_gtk_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/history/top_sites_unittest.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/net/gaia/token_service.h	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/net/gaia/token_service.cc	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/net/gaia/token_service_unittest.cc	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notifications_unittest.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/notifications/notification_exceptions_table_model_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_default_unittest.cc	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_win_unittest.cc	View	3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/test/site_instance_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_model_unittest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_preference_unittest.cc	View	1	4 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_startup_unittest.cc	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_unittest.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_manager_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_unittest.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/translate/translate_manager_unittest.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/extensions/browser_action_drag_data_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/web_applications/web_app_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/testing_profile.h	View	1 2 3 4	6 chunks	+34 lines, -84 lines	0 comments	Download
M	chrome/test/testing_profile.cc	View	1 2 3 4	4 chunks	+96 lines, -1 line	0 comments	Download

Trybot results: mac win linux linux_view

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

4 years, 9 months ago (2010-08-12 23:31:23 UTC) #2

LGTM assuming it compiles. It's _amazing_ how many headers got taken out of
testing_profile.h.

Expand Messages | Collapse Messages