Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5540)

Unified Diff: chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.h

Issue 3129007: FBTF: Forward declare everything possible in testing_profile.h (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: argh mac problems now Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.h
diff --git a/chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.h b/chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.h
index c3d6e8324c470772d169791385f9a1d1642aade8..d35d1e9709d391ee28c66ba4b9b287d39be14900 100644
--- a/chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.h
+++ b/chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.h
@@ -17,6 +17,8 @@
#include "chrome/test/model_test_utils.h"
#include "testing/platform_test.h"
+class BookmarkModel;
+
// The fake object that acts as our app's delegate, useful for testing purposes.
@interface FakeAppDelegate : AppController {
@public
@@ -39,24 +41,13 @@
// The base class for all our bookmark releated unit tests.
class BookmarkAppleScriptTest : public CocoaTest {
public:
- BookmarkAppleScriptTest() {
- appDelegate_.reset([[FakeAppDelegate alloc] init]);
- [appDelegate_.get() setHelper:&helper_];
- [NSApp setDelegate:appDelegate_];
- const BookmarkNode* root = model().GetBookmarkBarNode();
- const std::wstring modelString(L"a f1:[ b d c ] d f2:[ e f g ] h ");
- model_test_utils::AddNodesFromModelString(model(), root, modelString);
- bookmarkBar_.reset([[BookmarkFolderAppleScript alloc]
- initWithBookmarkNode:model().GetBookmarkBarNode()]);
- }
+ BookmarkAppleScriptTest();
private:
BrowserTestHelper helper_;
scoped_nsobject<FakeAppDelegate> appDelegate_;
protected:
scoped_nsobject<BookmarkFolderAppleScript> bookmarkBar_;
- BookmarkModel& model() {
- return *helper_.profile()->GetBookmarkModel();
- }
+ BookmarkModel& model();
};
#endif

Powered by Google App Engine
This is Rietveld 408576698