Added linux-specific NP_Initialize function so that the plugin is properly in...

Added linux-specific NP_Initialize function so that the plugin is properly initialized. Also fixed the mime-type to be consistent with that on windows and mac.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55743

[tony, 2010-08-10 22:09:40]

This seems OK to me, but I don't really know the plugin code.  Maybe evan can
give a LGTM?

http://codereview.chromium.org/3129005/diff/1/2
File webkit/glue/plugins/test/npapi_test.cc (right):

http://codereview.chromium.org/3129005/diff/1/2#newcode117
webkit/glue/plugins/test/npapi_test.cc:117: #endif  // OS_POSIX
Nit: This comment is a bit confusing (the #if is POSIX and !OSX, but it's
actually the end of the #else clause).  Can you either remove it or maybe add a
comment to #else instead?

[Evan Martin, 2010-08-10 22:42:12]

http://codereview.chromium.org/3129005/diff/1/2
File webkit/glue/plugins/test/npapi_test.cc (right):

http://codereview.chromium.org/3129005/diff/1/2#newcode117
webkit/glue/plugins/test/npapi_test.cc:117: #endif  // OS_POSIX
I suggest instead something like


#if defined(OS_WIN) || defined(OS_MACOSX)
code as before
#elif defined(OS_POSIX)
the new code you added
#endif

[alokp, 2010-08-10 22:49:27]

http://codereview.chromium.org/3129005/diff/1/2
File webkit/glue/plugins/test/npapi_test.cc (right):

http://codereview.chromium.org/3129005/diff/1/2#newcode117
webkit/glue/plugins/test/npapi_test.cc:117: #endif  // OS_POSIX
On 2010/08/10 22:42:12, Evan Martin wrote:
> I suggest instead something like
> 
> 
> #if defined(OS_WIN) || defined(OS_MACOSX)
> code as before
> #elif defined(OS_POSIX)
> the new code you added
> #endif

Done.

[Evan Martin, 2010-08-10 22:50:23]

LGTM