Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 312883004: Reland 274558 - Move some extensions renderer resources to extensions_renderer_resources.grd. (Closed)

Created:
6 years, 6 months ago by Yoyo Zhou
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Reland 274558 - Move some extensions renderer resources to extensions_renderer_resources.grd. This patch fixes references in the .gyp to .js resource files. This breaks the remaining dependency from src/extensions to chrome resources files. BUG=368334 TBR=rockot@chromium.org,jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -4194 lines) Patch
M apps/shell/app_shell.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/chrome_repack_resources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/extensions/event_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/json_schema_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/messaging_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/safe_builtins_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/renderer/resources/extensions/app_runtime_custom_bindings.js View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/renderer/resources/extensions/binding.js View 1 chunk +0 lines, -434 lines 0 comments Download
D chrome/renderer/resources/extensions/context_menus_custom_bindings.js View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/renderer/resources/extensions/entry_id_manager.js View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/renderer/resources/extensions/event.js View 1 chunk +0 lines, -528 lines 0 comments Download
D chrome/renderer/resources/extensions/extension_custom_bindings.js View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/renderer/resources/extensions/greasemonkey_api.js View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/renderer/resources/extensions/i18n_custom_bindings.js View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/renderer/resources/extensions/image_util.js View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/renderer/resources/extensions/json_schema.js View 1 chunk +0 lines, -525 lines 0 comments Download
D chrome/renderer/resources/extensions/last_error.js View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/renderer/resources/extensions/messaging.js View 1 chunk +0 lines, -386 lines 0 comments Download
D chrome/renderer/resources/extensions/messaging_utils.js View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/renderer/resources/extensions/permissions_custom_bindings.js View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/renderer/resources/extensions/platform_app.css View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/renderer/resources/extensions/platform_app.js View 1 chunk +0 lines, -207 lines 0 comments Download
D chrome/renderer/resources/extensions/runtime_custom_bindings.js View 1 chunk +0 lines, -205 lines 0 comments Download
D chrome/renderer/resources/extensions/schema_utils.js View 1 chunk +0 lines, -156 lines 0 comments Download
D chrome/renderer/resources/extensions/send_request.js View 1 chunk +0 lines, -178 lines 0 comments Download
D chrome/renderer/resources/extensions/set_icon.js View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/renderer/resources/extensions/storage_area.js View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/renderer/resources/extensions/test_custom_bindings.js View 1 chunk +0 lines, -353 lines 0 comments Download
D chrome/renderer/resources/extensions/uncaught_exception_handler.js View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/renderer/resources/extensions/unload_event.js View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/renderer/resources/extensions/utils.js View 1 chunk +0 lines, -127 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 5 chunks +0 lines, -27 lines 0 comments Download
M extensions/DEPS View 2 chunks +1 line, -3 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +25 lines, -0 lines 0 comments Download
M extensions/extensions_resources.gyp View 1 chunk +12 lines, -0 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/resources/app_runtime_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/binding.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/context_menus_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/entry_id_manager.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/event.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/extension_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +45 lines, -0 lines 0 comments Download
A + extensions/renderer/resources/greasemonkey_api.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/i18n_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/image_util.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/json_schema.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/renderer/resources/last_error.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/messaging.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/messaging_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/permissions_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/platform_app.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/platform_app.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/runtime_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/schema_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/send_request.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/set_icon.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/storage_area.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/test_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/uncaught_exception_handler.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/unload_event.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/renderer/script_injection.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yoyo Zhou
FYI, you're TBR on this reland. Hopefully it goes well because the trybots didn't bat ...
6 years, 6 months ago (2014-06-03 23:27:31 UTC) #1
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 6 months ago (2014-06-03 23:27:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/312883004/1
6 years, 6 months ago (2014-06-03 23:28:26 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 11:09:26 UTC) #4
Message was sent while issue was closed. 
Change committed as 274764

Powered by Google App Engine
This is Rietveld 408576698