Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 312833002: Add test specs for a new experimental MSan tester. (Closed)

Created:
6 years, 6 months ago by earthdok
Modified:
6 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Visibility:
Public.

Description

Add test specs for a new experimental MSan tester. Also, add interactive_ui_unittests to the exising tester. BUG=178409 R=phajdan.jr@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274819

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove explicit compile target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
earthdok
6 years, 6 months ago (2014-06-03 16:22:12 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 6 months ago (2014-06-04 10:32:38 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/312833002/diff/1/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/312833002/diff/1/testing/buildbot/chromium.fyi.json#newcode215 testing/buildbot/chromium.fyi.json:215: "compile_targets": [ Actually looking at https://codereview.chromium.org/307353005/ this is not ...
6 years, 6 months ago (2014-06-04 10:36:28 UTC) #3
earthdok
https://codereview.chromium.org/312833002/diff/1/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/312833002/diff/1/testing/buildbot/chromium.fyi.json#newcode215 testing/buildbot/chromium.fyi.json:215: "compile_targets": [ On 2014/06/04 10:36:28, Paweł Hajdan Jr. wrote: ...
6 years, 6 months ago (2014-06-04 12:38:04 UTC) #4
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 6 months ago (2014-06-04 12:38:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/312833002/20001
6 years, 6 months ago (2014-06-04 12:38:30 UTC) #6
commit-bot: I haz the power
Change committed as 274819
6 years, 6 months ago (2014-06-04 14:17:56 UTC) #7
earthdok
6 years, 6 months ago (2014-06-04 15:51:15 UTC) #8
Message was sent while issue was closed.
On 2014/06/04 10:36:28, Paweł Hajdan Jr. wrote:
>
https://codereview.chromium.org/312833002/diff/1/testing/buildbot/chromium.fy...
> File testing/buildbot/chromium.fyi.json (right):
> 
>
https://codereview.chromium.org/312833002/diff/1/testing/buildbot/chromium.fy...
> testing/buildbot/chromium.fyi.json:215: "compile_targets": [
> Actually looking at https://codereview.chromium.org/307353005/ this is not
> needed. In the chromium recipes the builders automatically compile targets
> needed for dependent testers.

I don't think this is correct. The builder does not build browser_tests still:

http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20MSan/bui...

Powered by Google App Engine
This is Rietveld 408576698