DevTools: [Responsive design] shift-drag resize widget for more precise dragging

DevTools: [Responsive design] shift-drag resize widget for more precise dragging

This patch makes it possible to shift-drag resize widgets on responsive
design page to slow down their movement.

BUG=380190
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175473

[lushnikov, 2014-06-03 15:44:42]

Please, take a look

[dgozman, 2014-06-04 09:05:25]

https://codereview.chromium.org/312813002/diff/1/Source/devtools/front_end/Re...
File Source/devtools/front_end/ResponsiveDesignView.js (right):

https://codereview.chromium.org/312813002/diff/1/Source/devtools/front_end/Re...
Source/devtools/front_end/ResponsiveDesignView.js:178: if (event.data.shiftKey
!== !!this._slowPositionStart)
You will miss first update if shift was pressed before drag start. There have to
be similar |_slowPositionStart| update in |_onResizeStart|.

https://codereview.chromium.org/312813002/diff/1/Source/devtools/front_end/ui...
File Source/devtools/front_end/ui/ResizerWidget.js (right):

https://codereview.chromium.org/312813002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/ResizerWidget.js:21: ResizeUpdate: "ResizeUpdate", 
// Data: {{startPosition: number, currentPosition: number}}.
Please update this.

[lushnikov, 2014-06-04 09:14:38]

https://codereview.chromium.org/312813002/diff/1/Source/devtools/front_end/Re...
File Source/devtools/front_end/ResponsiveDesignView.js (right):

https://codereview.chromium.org/312813002/diff/1/Source/devtools/front_end/Re...
Source/devtools/front_end/ResponsiveDesignView.js:178: if (event.data.shiftKey
!== !!this._slowPositionStart)
Yep, that's intentional - it doesn't affect actual usability, but saves us
couple of lines of code.

https://codereview.chromium.org/312813002/diff/1/Source/devtools/front_end/ui...
File Source/devtools/front_end/ui/ResizerWidget.js (right):

https://codereview.chromium.org/312813002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/ResizerWidget.js:21: ResizeUpdate: "ResizeUpdate", 
// Data: {{startPosition: number, currentPosition: number}}.
On 2014/06/04 09:05:24, dgozman wrote:
> Please update this.

Removed these comments.

[lushnikov, 2014-06-04 09:15:42]

https://codereview.chromium.org/312813002/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/ResponsiveDesignView.js (right):

https://codereview.chromium.org/312813002/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/ResponsiveDesignView.js:181: var dipOffset =
Math.round(cssOffset * WebInspector.zoomManager.zoomFactor());
added Math.round statement we've talked about.

[dgozman, 2014-06-04 09:32:39]

lgtm

[lushnikov, 2014-06-04 09:34:26]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2014-06-04 09:35:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lushnikov@chromium.org/312813002/20001

[commit-bot: I haz the power, 2014-06-04 10:43:20]

Change committed as 175473