content/browser/media/capture/desktop_capture_device_aura.cc - Issue 312803002: Android media: VideoFrame should not store so many sync points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/capture/desktop_capture_device_aura.cc

Issue 312803002: Android media: VideoFrame should not store so many sync points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address danakj@'s concern Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/resources/video_resource_updater.cc ('K') | « cc/resources/video_resource_updater.cc ('k') | content/browser/renderer_host/media/video_capture_controller.h » ('j') | content/browser/renderer_host/media/video_capture_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/capture/desktop_capture_device_aura.cc

diff --git a/content/browser/media/capture/desktop_capture_device_aura.cc b/content/browser/media/capture/desktop_capture_device_aura.cc

index 432a1854019aab49d9876a3fe646b0bb31fe9ff5..7285d44f7cabfedf7770029da631f241744acbb7 100644

--- a/content/browser/media/capture/desktop_capture_device_aura.cc

+++ b/content/browser/media/capture/desktop_capture_device_aura.cc

@@ -305,14 +305,9 @@ void CopyOutputFinishedForVideo(

}

void RunSingleReleaseCallback(scoped_ptr<cc::SingleReleaseCallback> cb,

- const std::vector<uint32>& sync_points) {

+ uint32 sync_point) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

- GLHelper* gl_helper = ImageTransportFactory::GetInstance()->GetGLHelper();

- DCHECK(gl_helper);

- for (unsigned i = 0; i < sync_points.size(); i++)

- gl_helper->WaitSyncPoint(sync_points[i]);

- uint32 new_sync_point = gl_helper->InsertSyncPoint();

- cb->Run(new_sync_point, false);

+ cb->Run(sync_point, false);

}

void DesktopVideoCaptureMachine::DidCopyOutput(