content/common/media/video_capture_messages.h - Issue 312803002: Android media: VideoFrame should not store so many sync points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/media/video_capture_messages.h

Issue 312803002: Android media: VideoFrame should not store so many sync points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make VideoFrame keep only one sync point per client Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/resources/video_resource_updater.cc ('K') | « content/browser/renderer_host/media/video_capture_host_unittest.cc ('k') | content/renderer/media/android/webmediaplayer_android.cc » ('j') | content/renderer/media/android/webmediaplayer_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/media/video_capture_messages.h

diff --git a/content/common/media/video_capture_messages.h b/content/common/media/video_capture_messages.h

index c3970df76f80592a0f389077d5db1c43d53ec9db..8778eb8360d0f58a78551f0d5045e56654d8ee14 100644

--- a/content/common/media/video_capture_messages.h

+++ b/content/common/media/video_capture_messages.h

@@ -89,10 +89,13 @@ IPC_MESSAGE_CONTROL1(VideoCaptureHostMsg_Stop,

// Tell the browser process that the renderer has finished reading from

// a buffer previously delivered by VideoCaptureMsg_BufferReady.

+// Define SyncPoints so that macro compiler considers std::map as one argument.

+// See http://www.boost.org/doc/libs/1_48_0/doc/html/foreach/pitfalls.html

+typedef std::map<uintptr_t, uint32> SyncPoints;

IPC_MESSAGE_CONTROL3(VideoCaptureHostMsg_BufferReady,

int /* device_id */,

int /* buffer_id */,

- std::vector<uint32> /* syncpoints */)

+ SyncPoints)

// Get the formats supported by a device referenced by |capture_session_id|.

IPC_MESSAGE_CONTROL2(VideoCaptureHostMsg_GetDeviceSupportedFormats,