Android media: VideoFrame should not store so many sync points.

content/browser/renderer_host/image_transport_factory_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/image_transport_factory_android.h"
 
 #include "base/lazy_instance.h"
 #include "base/strings/stringprintf.h"
 #include "content/browser/gpu/browser_gpu_channel_host_factory.h"
 #include "content/common/gpu/client/gl_helper.h"
@@ skipping 86 matching lines @@
   if (!gl_helper_)
     gl_helper_.reset(new GLHelper(context_->GetImplementation(),
                                   context_->GetContextSupport()));
 
   return gl_helper_.get();
 }
 
 }  // anonymous namespace
 
 // static
+void ImageTransportFactoryAndroid::InitializeForUnitTests(

[no sievers, 2014/07/10 18:52:29]

Do we need a method for teardown also?

With unit tests it can create this nasty problems when you leak static objects
depending on how they run. 

[dshwang, 2014/07/10 19:23:11]

Ah, you're right. I mimic this method after
ImageTransportFactory::InitializeForUnitTests(scoped_ptr<ImageTransportFactory>
factory).
ImageTransportFactory class has Terminate() method for this reason!. I'll
update.

+    ImageTransportFactoryAndroid* test_factory) {
+  DCHECK(!g_factory);
+  g_factory = test_factory;
+}
+
+// static
 ImageTransportFactoryAndroid* ImageTransportFactoryAndroid::GetInstance() {
   if (!g_factory)
     g_factory = new CmdBufferImageTransportFactory();
 
   return g_factory;
 }
 
 ImageTransportFactoryAndroid::ImageTransportFactoryAndroid()
     : context_lost_listener_(new GLContextLostListener()) {}
 
@@ skipping 20 matching lines @@
 
 void GLContextLostListener::DidLoseContext() {
   delete g_factory;
   g_factory = NULL;
   FOR_EACH_OBSERVER(ImageTransportFactoryAndroidObserver,
       g_factory_observers.Get(),
       OnLostResources());
 }
 
 } // namespace content