Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2232)

Unified Diff: sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart

Issue 312793002: dart2dart: Preserve variable names throughout the IR. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Properly linearize phi assignments, remove unused write count Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart b/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart
index 6305433b93d6751fda552ed60c73fac4dc2d548a..3e5f12ae6b8820a64c9bbca44e24a80052222ca0 100644
--- a/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart
+++ b/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart
@@ -191,6 +191,7 @@ class IrBuilder extends ResolvedVisitor<ir.Primitive> {
// used to determine if a join-point continuation needs to be passed
// arguments, and what the arguments are.
final Map<Element, int> variableIndex;
+ final List<Element> index2variable;
final List<ir.Parameter> freeVars;
final List<ir.Primitive> assignedVars;
@@ -201,6 +202,7 @@ class IrBuilder extends ResolvedVisitor<ir.Primitive> {
variableIndex = <Element, int>{},
freeVars = null,
assignedVars = <ir.Primitive>[],
+ index2variable = <Element>[],
super(elements, compiler);
/// Construct a delimited visitor.
@@ -214,6 +216,7 @@ class IrBuilder extends ResolvedVisitor<ir.Primitive> {
growable: false),
assignedVars = new List<ir.Primitive>.generate(
parent.assignedVars.length, (_) => null),
+ index2variable = new List<Element>.from(parent.index2variable),
super(parent.elements, parent.compiler);
/**
@@ -240,6 +243,7 @@ class IrBuilder extends ResolvedVisitor<ir.Primitive> {
parameters.add(parameter);
variableIndex[parameterElement] = assignedVars.length;
assignedVars.add(parameter);
+ index2variable.add(parameterElement);
});
visit(function.body);
@@ -345,7 +349,7 @@ class IrBuilder extends ResolvedVisitor<ir.Primitive> {
// left and right subterms we will still have a join continuation with
// possibly arguments passed to it. Such singly-used continuations
// are eliminated by the shrinking conversions.
- parameters.add(new ir.Parameter(null));
+ parameters.add(new ir.Parameter(index2variable[i]));
ir.Primitive reachingDefinition =
assignedVars[i] == null ? freeVars[i] : assignedVars[i];
leftArguments.add(
@@ -395,7 +399,7 @@ class IrBuilder extends ResolvedVisitor<ir.Primitive> {
// If not, no value needs to be passed to the join point.
if (reachingAssignment == null) continue;
- parameters.add(new ir.Parameter(null));
+ parameters.add(new ir.Parameter(index2variable[i]));
ir.Definition entryAssignment = assignedVars[i];
entryArguments.add(
entryAssignment == null ? freeVars[i] : entryAssignment);
@@ -628,16 +632,22 @@ class IrBuilder extends ResolvedVisitor<ir.Primitive> {
assert(!definition.arguments.isEmpty);
assert(definition.arguments.tail.isEmpty);
ir.Primitive initialValue = visit(definition.arguments.head);
+ // In case a primitive was introduced for the initializer expression,
+ // use this variable element to help derive a good name for it.
+ initialValue.useElementAsHint(element);
variableIndex[element] = assignedVars.length;
assignedVars.add(initialValue);
+ index2variable.add(element);
} else {
assert(definition is ast.Identifier);
// The initial value is null.
// TODO(kmillikin): Consider pooling constants.
ir.Constant constant = new ir.Constant(constantSystem.createNull());
+ constant.useElementAsHint(element);
add(new ir.LetPrim(constant));
variableIndex[element] = assignedVars.length;
assignedVars.add(constant);
+ index2variable.add(element);
}
}
return null;
@@ -1090,6 +1100,7 @@ class IrBuilder extends ResolvedVisitor<ir.Primitive> {
assert(!node.arguments.isEmpty);
assert(node.arguments.tail.isEmpty);
result = visit(node.arguments.head);
+ result.useElementAsHint(element);
assignedVars[variableIndex[element]] = result;
return result;
} else if (Elements.isStaticOrTopLevel(element)) {
@@ -1146,6 +1157,7 @@ class IrBuilder extends ResolvedVisitor<ir.Primitive> {
assert(node.arguments.tail.isEmpty);
arg = visit(node.arguments.head);
}
+ arg.useElementAsHint(element);
result = new ir.Parameter(null);
ir.Continuation k = new ir.Continuation([result]);
ir.Expression invoke = new ir.InvokeMethod(getter, selector, k, [arg]);

Powered by Google App Engine
This is Rietveld 408576698