Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: content/renderer/media/media_stream_impl.cc

Issue 312773002: Support for audio output devices for getMediaDevices. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/media_stream_impl.h" 5 #include "content/renderer/media/media_stream_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/hash.h"
9 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/string_util.h" 12 #include "base/strings/string_util.h"
11 #include "base/strings/stringprintf.h" 13 #include "base/strings/stringprintf.h"
12 #include "base/strings/utf_string_conversions.h" 14 #include "base/strings/utf_string_conversions.h"
13 #include "content/renderer/media/media_stream.h" 15 #include "content/renderer/media/media_stream.h"
14 #include "content/renderer/media/media_stream_audio_source.h" 16 #include "content/renderer/media/media_stream_audio_source.h"
15 #include "content/renderer/media/media_stream_dispatcher.h" 17 #include "content/renderer/media/media_stream_dispatcher.h"
16 #include "content/renderer/media/media_stream_video_capturer_source.h" 18 #include "content/renderer/media/media_stream_video_capturer_source.h"
17 #include "content/renderer/media/media_stream_video_track.h" 19 #include "content/renderer/media/media_stream_video_track.h"
18 #include "content/renderer/media/peer_connection_tracker.h" 20 #include "content/renderer/media/peer_connection_tracker.h"
19 #include "content/renderer/media/webrtc/webrtc_video_capturer_adapter.h" 21 #include "content/renderer/media/webrtc/webrtc_video_capturer_adapter.h"
(...skipping 30 matching lines...) Expand all
50 } 52 }
51 } 53 }
52 54
53 static int g_next_request_id = 0; 55 static int g_next_request_id = 0;
54 56
55 } // namespace 57 } // namespace
56 58
57 struct MediaStreamImpl::MediaDevicesRequestInfo { 59 struct MediaStreamImpl::MediaDevicesRequestInfo {
58 MediaDevicesRequestInfo(const blink::WebMediaDevicesRequest& request, 60 MediaDevicesRequestInfo(const blink::WebMediaDevicesRequest& request,
59 int audio_input_request_id, 61 int audio_input_request_id,
60 int video_input_request_id) 62 int video_input_request_id,
63 int audio_output_request_id)
61 : request(request), 64 : request(request),
62 audio_input_request_id(audio_input_request_id), 65 audio_input_request_id(audio_input_request_id),
63 video_input_request_id(video_input_request_id), 66 video_input_request_id(video_input_request_id),
67 audio_output_request_id(audio_output_request_id),
64 has_audio_input_returned(false), 68 has_audio_input_returned(false),
65 has_video_input_returned(false) {} 69 has_video_input_returned(false),
70 has_audio_output_returned(false) {}
66 71
67 blink::WebMediaDevicesRequest request; 72 blink::WebMediaDevicesRequest request;
68 int audio_input_request_id; 73 int audio_input_request_id;
69 int video_input_request_id; 74 int video_input_request_id;
75 int audio_output_request_id;
70 bool has_audio_input_returned; 76 bool has_audio_input_returned;
71 bool has_video_input_returned; 77 bool has_video_input_returned;
78 bool has_audio_output_returned;
72 StreamDeviceInfoArray audio_input_devices; 79 StreamDeviceInfoArray audio_input_devices;
73 StreamDeviceInfoArray video_input_devices; 80 StreamDeviceInfoArray video_input_devices;
81 StreamDeviceInfoArray audio_output_devices;
74 }; 82 };
75 83
76 MediaStreamImpl::MediaStreamImpl( 84 MediaStreamImpl::MediaStreamImpl(
77 RenderView* render_view, 85 RenderView* render_view,
78 MediaStreamDispatcher* media_stream_dispatcher, 86 MediaStreamDispatcher* media_stream_dispatcher,
79 PeerConnectionDependencyFactory* dependency_factory) 87 PeerConnectionDependencyFactory* dependency_factory)
80 : RenderViewObserver(render_view), 88 : RenderViewObserver(render_view),
81 dependency_factory_(dependency_factory), 89 dependency_factory_(dependency_factory),
82 media_stream_dispatcher_(media_stream_dispatcher) { 90 media_stream_dispatcher_(media_stream_dispatcher) {
83 } 91 }
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 } 198 }
191 } 199 }
192 200
193 void MediaStreamImpl::requestMediaDevices( 201 void MediaStreamImpl::requestMediaDevices(
194 const blink::WebMediaDevicesRequest& media_devices_request) { 202 const blink::WebMediaDevicesRequest& media_devices_request) {
195 UpdateWebRTCMethodCount(WEBKIT_GET_MEDIA_DEVICES); 203 UpdateWebRTCMethodCount(WEBKIT_GET_MEDIA_DEVICES);
196 DCHECK(CalledOnValidThread()); 204 DCHECK(CalledOnValidThread());
197 205
198 int audio_input_request_id = g_next_request_id++; 206 int audio_input_request_id = g_next_request_id++;
199 int video_input_request_id = g_next_request_id++; 207 int video_input_request_id = g_next_request_id++;
208 int audio_output_request_id = g_next_request_id++;
200 209
201 // |media_devices_request| can't be mocked, so in tests it will be empty (the 210 // |media_devices_request| can't be mocked, so in tests it will be empty (the
202 // underlying pointer is null). In order to use this function in a test we 211 // underlying pointer is null). In order to use this function in a test we
203 // need to check if it isNull. 212 // need to check if it isNull.
204 GURL security_origin; 213 GURL security_origin;
205 if (!media_devices_request.isNull()) 214 if (!media_devices_request.isNull())
206 security_origin = GURL(media_devices_request.securityOrigin().toString()); 215 security_origin = GURL(media_devices_request.securityOrigin().toString());
207 216
208 DVLOG(1) << "MediaStreamImpl::requestMediaDevices(" << audio_input_request_id 217 DVLOG(1) << "MediaStreamImpl::requestMediaDevices(" << audio_input_request_id
209 << ", " << video_input_request_id << ", " 218 << ", " << video_input_request_id << ", " << audio_output_request_id
210 << security_origin.spec() << ")"; 219 << ", " << security_origin.spec() << ")";
211 220
212 media_devices_requests_.push_back(new MediaDevicesRequestInfo( 221 media_devices_requests_.push_back(new MediaDevicesRequestInfo(
213 media_devices_request, audio_input_request_id, video_input_request_id)); 222 media_devices_request,
223 audio_input_request_id,
224 video_input_request_id,
225 audio_output_request_id));
214 226
215 media_stream_dispatcher_->EnumerateDevices( 227 media_stream_dispatcher_->EnumerateDevices(
216 audio_input_request_id, 228 audio_input_request_id,
217 AsWeakPtr(), 229 AsWeakPtr(),
218 MEDIA_DEVICE_AUDIO_CAPTURE, 230 MEDIA_DEVICE_AUDIO_CAPTURE,
219 security_origin); 231 security_origin);
220 232
221 media_stream_dispatcher_->EnumerateDevices( 233 media_stream_dispatcher_->EnumerateDevices(
222 video_input_request_id, 234 video_input_request_id,
223 AsWeakPtr(), 235 AsWeakPtr(),
224 MEDIA_DEVICE_VIDEO_CAPTURE, 236 MEDIA_DEVICE_VIDEO_CAPTURE,
225 security_origin); 237 security_origin);
238
239 media_stream_dispatcher_->EnumerateDevices(
240 audio_output_request_id,
241 AsWeakPtr(),
242 MEDIA_DEVICE_AUDIO_OUTPUT,
243 security_origin);
226 } 244 }
227 245
228 void MediaStreamImpl::cancelMediaDevicesRequest( 246 void MediaStreamImpl::cancelMediaDevicesRequest(
229 const blink::WebMediaDevicesRequest& media_devices_request) { 247 const blink::WebMediaDevicesRequest& media_devices_request) {
230 DCHECK(CalledOnValidThread()); 248 DCHECK(CalledOnValidThread());
231 MediaDevicesRequestInfo* request = 249 MediaDevicesRequestInfo* request =
232 FindMediaDevicesRequestInfo(media_devices_request); 250 FindMediaDevicesRequestInfo(media_devices_request);
233 if (!request) 251 if (!request)
234 return; 252 return;
235 253
236 // Cancel device enumeration. 254 // Cancel device enumeration.
237 media_stream_dispatcher_->StopEnumerateDevices( 255 media_stream_dispatcher_->StopEnumerateDevices(
238 request->audio_input_request_id, 256 request->audio_input_request_id,
239 AsWeakPtr()); 257 AsWeakPtr());
240 media_stream_dispatcher_->StopEnumerateDevices( 258 media_stream_dispatcher_->StopEnumerateDevices(
241 request->video_input_request_id, 259 request->video_input_request_id,
242 AsWeakPtr()); 260 AsWeakPtr());
261 media_stream_dispatcher_->StopEnumerateDevices(
262 request->audio_output_request_id,
263 AsWeakPtr());
243 DeleteMediaDevicesRequestInfo(request); 264 DeleteMediaDevicesRequestInfo(request);
244 } 265 }
245 266
246 // Callback from MediaStreamDispatcher. 267 // Callback from MediaStreamDispatcher.
247 // The requested stream have been generated by the MediaStreamDispatcher. 268 // The requested stream have been generated by the MediaStreamDispatcher.
248 void MediaStreamImpl::OnStreamGenerated( 269 void MediaStreamImpl::OnStreamGenerated(
249 int request_id, 270 int request_id,
250 const std::string& label, 271 const std::string& label,
251 const StreamDeviceInfoArray& audio_array, 272 const StreamDeviceInfoArray& audio_array,
252 const StreamDeviceInfoArray& video_array) { 273 const StreamDeviceInfoArray& video_array) {
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
493 const StreamDeviceInfoArray& device_array) { 514 const StreamDeviceInfoArray& device_array) {
494 DVLOG(1) << "MediaStreamImpl::OnDevicesEnumerated(" << request_id << ")"; 515 DVLOG(1) << "MediaStreamImpl::OnDevicesEnumerated(" << request_id << ")";
495 516
496 MediaDevicesRequestInfo* request = FindMediaDevicesRequestInfo(request_id); 517 MediaDevicesRequestInfo* request = FindMediaDevicesRequestInfo(request_id);
497 DCHECK(request); 518 DCHECK(request);
498 519
499 if (request_id == request->audio_input_request_id) { 520 if (request_id == request->audio_input_request_id) {
500 request->has_audio_input_returned = true; 521 request->has_audio_input_returned = true;
501 DCHECK(request->audio_input_devices.empty()); 522 DCHECK(request->audio_input_devices.empty());
502 request->audio_input_devices = device_array; 523 request->audio_input_devices = device_array;
503 } else { 524 } else if (request_id == request->video_input_request_id) {
504 DCHECK(request_id == request->video_input_request_id);
505 request->has_video_input_returned = true; 525 request->has_video_input_returned = true;
506 DCHECK(request->video_input_devices.empty()); 526 DCHECK(request->video_input_devices.empty());
507 request->video_input_devices = device_array; 527 request->video_input_devices = device_array;
528 } else {
529 DCHECK_EQ(request->audio_output_request_id, request_id);
530 request->has_audio_output_returned = true;
531 DCHECK(request->audio_output_devices.empty());
532 request->audio_output_devices = device_array;
508 } 533 }
509 534
510 if (!request->has_audio_input_returned || 535 if (!request->has_audio_input_returned ||
511 !request->has_video_input_returned) { 536 !request->has_video_input_returned ||
537 !request->has_audio_output_returned) {
512 // Wait for the rest of the devices to complete. 538 // Wait for the rest of the devices to complete.
513 return; 539 return;
514 } 540 }
515 541
516 // Both audio and video devices are ready for copying. 542 // All devices are ready for copying. We use a hashed audio output device id
517 // TODO(grunell): Add support for output devices and group id. 543 // as the group id for input and output audio devices. If an input device
544 // doesn't have an associated output device, we use the input device's own id.
545 // We don't support group id for video devices, that's left empty.
518 blink::WebVector<blink::WebMediaDeviceInfo> 546 blink::WebVector<blink::WebMediaDeviceInfo>
519 devices(request->audio_input_devices.size() + 547 devices(request->audio_input_devices.size() +
520 request->video_input_devices.size()); 548 request->video_input_devices.size() +
549 request->audio_output_devices.size());
521 for (size_t i = 0; i < request->audio_input_devices.size(); ++i) { 550 for (size_t i = 0; i < request->audio_input_devices.size(); ++i) {
522 const MediaStreamDevice& device = request->audio_input_devices[i].device; 551 const MediaStreamDevice& device = request->audio_input_devices[i].device;
523 DCHECK_EQ(device.type, MEDIA_DEVICE_AUDIO_CAPTURE); 552 DCHECK_EQ(device.type, MEDIA_DEVICE_AUDIO_CAPTURE);
524 devices[i].initialize(blink::WebString::fromUTF8(device.id), 553 std::string group_id = base::UintToString(base::Hash(
525 blink::WebMediaDeviceInfo::MediaDeviceKindAudioInput, 554 !device.matched_output_device_id.empty() ?
526 blink::WebString::fromUTF8(device.name), 555 device.matched_output_device_id :
527 blink::WebString()); 556 device.id));
557 devices[i].initialize(
558 blink::WebString::fromUTF8(device.id),
559 blink::WebMediaDeviceInfo::MediaDeviceKindAudioInput,
560 blink::WebString::fromUTF8(device.name),
561 blink::WebString::fromUTF8(group_id));
528 } 562 }
529 size_t audio_size = request->audio_input_devices.size(); 563 size_t offset = request->audio_input_devices.size();
530 for (size_t i = 0; i < request->video_input_devices.size(); ++i) { 564 for (size_t i = 0; i < request->video_input_devices.size(); ++i) {
531 const MediaStreamDevice& device = request->video_input_devices[i].device; 565 const MediaStreamDevice& device = request->video_input_devices[i].device;
532 DCHECK_EQ(device.type, MEDIA_DEVICE_VIDEO_CAPTURE); 566 DCHECK_EQ(device.type, MEDIA_DEVICE_VIDEO_CAPTURE);
533 devices[audio_size + i].initialize( 567 devices[offset + i].initialize(
534 blink::WebString::fromUTF8(device.id), 568 blink::WebString::fromUTF8(device.id),
535 blink::WebMediaDeviceInfo::MediaDeviceKindVideoInput, 569 blink::WebMediaDeviceInfo::MediaDeviceKindVideoInput,
536 blink::WebString::fromUTF8(device.name), 570 blink::WebString::fromUTF8(device.name),
537 blink::WebString()); 571 blink::WebString());
538 } 572 }
573 offset += request->video_input_devices.size();
574 for (size_t i = 0; i < request->audio_output_devices.size(); ++i) {
575 const MediaStreamDevice& device = request->audio_output_devices[i].device;
576 DCHECK_EQ(device.type, MEDIA_DEVICE_AUDIO_OUTPUT);
577 devices[offset + i].initialize(
578 blink::WebString::fromUTF8(device.id),
579 blink::WebMediaDeviceInfo::MediaDeviceKindAudioOutput,
580 blink::WebString::fromUTF8(device.name),
581 blink::WebString::fromUTF8(base::UintToString(base::Hash(device.id))));
582 }
539 583
540 EnumerateDevicesSucceded(&request->request, devices); 584 EnumerateDevicesSucceded(&request->request, devices);
541 585
542 // Cancel device enumeration. 586 // Cancel device enumeration.
543 media_stream_dispatcher_->StopEnumerateDevices( 587 media_stream_dispatcher_->StopEnumerateDevices(
544 request->audio_input_request_id, 588 request->audio_input_request_id,
545 AsWeakPtr()); 589 AsWeakPtr());
546 media_stream_dispatcher_->StopEnumerateDevices( 590 media_stream_dispatcher_->StopEnumerateDevices(
547 request->video_input_request_id, 591 request->video_input_request_id,
548 AsWeakPtr()); 592 AsWeakPtr());
593 media_stream_dispatcher_->StopEnumerateDevices(
594 request->audio_output_request_id,
595 AsWeakPtr());
549 596
550 DeleteMediaDevicesRequestInfo(request); 597 DeleteMediaDevicesRequestInfo(request);
551 } 598 }
552 599
553 void MediaStreamImpl::OnDeviceOpened( 600 void MediaStreamImpl::OnDeviceOpened(
554 int request_id, 601 int request_id,
555 const std::string& label, 602 const std::string& label,
556 const StreamDeviceInfo& video_device) { 603 const StreamDeviceInfo& video_device) {
557 DVLOG(1) << "MediaStreamImpl::OnDeviceOpened(" 604 DVLOG(1) << "MediaStreamImpl::OnDeviceOpened("
558 << request_id << ", " << label << ")"; 605 << request_id << ", " << label << ")";
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
666 } 713 }
667 NOTREACHED(); 714 NOTREACHED();
668 } 715 }
669 716
670 MediaStreamImpl::MediaDevicesRequestInfo* 717 MediaStreamImpl::MediaDevicesRequestInfo*
671 MediaStreamImpl::FindMediaDevicesRequestInfo( 718 MediaStreamImpl::FindMediaDevicesRequestInfo(
672 int request_id) { 719 int request_id) {
673 MediaDevicesRequests::iterator it = media_devices_requests_.begin(); 720 MediaDevicesRequests::iterator it = media_devices_requests_.begin();
674 for (; it != media_devices_requests_.end(); ++it) { 721 for (; it != media_devices_requests_.end(); ++it) {
675 if ((*it)->audio_input_request_id == request_id || 722 if ((*it)->audio_input_request_id == request_id ||
676 (*it)->video_input_request_id == request_id) { 723 (*it)->video_input_request_id == request_id ||
724 (*it)->audio_output_request_id == request_id) {
677 return (*it); 725 return (*it);
678 } 726 }
679 } 727 }
680 return NULL; 728 return NULL;
681 } 729 }
682 730
683 MediaStreamImpl::MediaDevicesRequestInfo* 731 MediaStreamImpl::MediaDevicesRequestInfo*
684 MediaStreamImpl::FindMediaDevicesRequestInfo( 732 MediaStreamImpl::FindMediaDevicesRequestInfo(
685 const blink::WebMediaDevicesRequest& request) { 733 const blink::WebMediaDevicesRequest& request) {
686 MediaDevicesRequests::iterator it = media_devices_requests_.begin(); 734 MediaDevicesRequests::iterator it = media_devices_requests_.begin();
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
878 sources_.begin(); 926 sources_.begin();
879 it != sources_.end(); ++it) { 927 it != sources_.end(); ++it) {
880 if (source.id() == it->id()) { 928 if (source.id() == it->id()) {
881 sources_.erase(it); 929 sources_.erase(it);
882 return; 930 return;
883 } 931 }
884 } 932 }
885 } 933 }
886 934
887 } // namespace content 935 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/media/media_stream_dispatcher_unittest.cc ('k') | content/renderer/media/media_stream_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698