Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 312763002: Add DEPS files and run checkdeps in presubmit check (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add DEPS files and run checkdeps in presubmit check BUG=none R=jkummerow@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
M DEPS View 1 chunk +12 lines, -0 lines 0 comments Download
M PRESUBMIT.py View 2 chunks +57 lines, -0 lines 0 comments Download
A src/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A src/base/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A src/libplatform/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A test/cctest/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/DEPS View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-03 12:35:51 UTC) #1
Jakob Kummerow
lgtm
6 years, 6 months ago (2014-06-03 12:40:02 UTC) #2
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-03 13:40:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21642 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698