Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: pkg/watcher/test/utils.dart

Issue 312743002: Use 'Directory.watch' on Windows in pkg/watcher, instead of pooling. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/watcher/test/utils.dart
diff --git a/pkg/watcher/test/utils.dart b/pkg/watcher/test/utils.dart
index b520bbd9a94ee75a08816a6d54e5622a6d1ff862..ec3b22f837683ef25e635153f7287ed538443551 100644
--- a/pkg/watcher/test/utils.dart
+++ b/pkg/watcher/test/utils.dart
@@ -71,6 +71,11 @@ void createSandbox() {
// Delete the sandbox when done.
currentSchedule.onComplete.schedule(() {
if (_sandboxDir != null) {
+ // TODO(rnystrom): The wacthers should already be closed when we clean up
kasperl 2014/06/03 11:28:09 wacthers -> watchers. File an issue for this inste
Anders Johnsen 2014/06/03 11:44:14 Done.
+ // the sandbox.
+ if (_watcherEvents != null) {
+ _watcherEvents.close();
+ }
new Directory(_sandboxDir).deleteSync(recursive: true);
_sandboxDir = null;
}

Powered by Google App Engine
This is Rietveld 408576698