pkg/watcher/lib/src/directory_watcher.dart - Issue 312743002: Use 'Directory.watch' on Windows in pkg/watcher, instead of pooling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/watcher/lib/src/directory_watcher.dart

Issue 312743002: Use 'Directory.watch' on Windows in pkg/watcher, instead of pooling. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/test/physical_resource_provider_test.dart ('K') | « pkg/pkg.status ('k') | pkg/watcher/lib/src/directory_watcher/windows.dart » ('j') | pkg/watcher/lib/src/directory_watcher/windows.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/watcher/lib/src/directory_watcher.dart

diff --git a/pkg/watcher/lib/src/directory_watcher.dart b/pkg/watcher/lib/src/directory_watcher.dart

index 78b1174e189646560f12414afc615499fb8b99b7..27dbb3f5101f56e5bcb8fa08f5b2d4a177362676 100644

--- a/pkg/watcher/lib/src/directory_watcher.dart

+++ b/pkg/watcher/lib/src/directory_watcher.dart

@@ -10,6 +10,7 @@ import 'dart:io';

import 'watch_event.dart';

import 'directory_watcher/linux.dart';

import 'directory_watcher/mac_os.dart';

+import 'directory_watcher/windows.dart';

import 'directory_watcher/polling.dart';

/// Watches the contents of a directory and emits [WatchEvent]s when something

@@ -56,6 +57,7 @@ abstract class DirectoryWatcher {

factory DirectoryWatcher(String directory, {Duration pollingDelay}) {

if (Platform.isLinux) return new LinuxDirectoryWatcher(directory);

if (Platform.isMacOS) return new MacOSDirectoryWatcher(directory);

+ if (Platform.isWindows) return new WindowsDirectoryWatcher(directory);

return new PollingDirectoryWatcher(directory, pollingDelay: pollingDelay);

Søren Gjesse 2014/06/03 14:14:53 Do we still need this last return? We only have th

Anders Johnsen 2014/06/04 08:46:46 Android?

}