runtime/bin/file_system_watcher_win.cc - Issue 312743002: Use 'Directory.watch' on Windows in pkg/watcher, instead of pooling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file_system_watcher_win.cc

Issue 312743002: Use 'Directory.watch' on Windows in pkg/watcher, instead of pooling. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixes Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/file_system_watcher_win.cc

diff --git a/runtime/bin/file_system_watcher_win.cc b/runtime/bin/file_system_watcher_win.cc

index adb2426076b830dff82ae686c7872d8f95c3f6ef..f0b71f1c3225fea4a94c716eb116884cd46ff477 100644

--- a/runtime/bin/file_system_watcher_win.cc

+++ b/runtime/bin/file_system_watcher_win.cc

@@ -73,7 +73,9 @@ intptr_t FileSystemWatcher::WatchPath(intptr_t id,

void FileSystemWatcher::UnwatchPath(intptr_t id, intptr_t path_id) {

USE(id);

- USE(path_id);

+ DirectoryWatchHandle* handle =

+ reinterpret_cast<DirectoryWatchHandle*>(path_id);

+ handle->Stop();

}

« runtime/bin/eventhandler_win.cc ('K') | « runtime/bin/file_patch.dart ('k') | no next file » | no next file with comments »