Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 312733002: Return dart:html scroll* etc types to int (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_Element.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate
index 225b31d80fd4e83b80350cb5a50c7c894d9b775d..82b76d5f44e1fcbf3ad0502504d0a202870d70c9 100644
--- a/tools/dom/templates/html/impl/impl_Element.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Element.darttemplate
@@ -1328,116 +1328,116 @@ $endif
$if DART2JS
@DomName('Element.offsetHeight')
@DocsEditable()
- num get offsetHeight => JS('num', '#.offsetHeight', this).round();
+ int get offsetHeight => JS('int', '#.offsetHeight', this).round();
vsm 2014/06/03 10:50:45 The JS type probably should be num. I.e., JS('num
Leaf 2014/06/03 11:01:42 Done.
@DomName('Element.offsetLeft')
@DocsEditable()
- num get offsetLeft => JS('num', '#.offsetLeft', this).round();
+ int get offsetLeft => JS('int', '#.offsetLeft', this).round();
@DomName('Element.offsetTop')
@DocsEditable()
- num get offsetTop => JS('num', '#.offsetTop', this).round();
+ int get offsetTop => JS('int', '#.offsetTop', this).round();
@DomName('Element.offsetWidth')
@DocsEditable()
- num get offsetWidth => JS('num', '#.offsetWidth', this).round();
+ int get offsetWidth => JS('int', '#.offsetWidth', this).round();
@DomName('Element.clientHeight')
@DocsEditable()
- num get clientHeight => JS('num', '#.clientHeight', this).round();
+ int get clientHeight => JS('int', '#.clientHeight', this).round();
@DomName('Element.clientLeft')
@DocsEditable()
- num get clientLeft => JS('num', '#.clientLeft', this).round();
+ int get clientLeft => JS('int', '#.clientLeft', this).round();
@DomName('Element.clientTop')
@DocsEditable()
- num get clientTop => JS('num', '#.clientTop', this).round();
+ int get clientTop => JS('int', '#.clientTop', this).round();
@DomName('Element.clientWidth')
@DocsEditable()
- num get clientWidth => JS('num', '#.clientWidth', this).round();
+ int get clientWidth => JS('int', '#.clientWidth', this).round();
@DomName('Element.scrollHeight')
@DocsEditable()
- num get scrollHeight => JS('num', '#.scrollHeight', this).round();
+ int get scrollHeight => JS('int', '#.scrollHeight', this).round();
@DomName('Element.scrollLeft')
@DocsEditable()
- num get scrollLeft => JS('num', '#.scrollLeft', this).round();
+ int get scrollLeft => JS('int', '#.scrollLeft', this).round();
@DomName('Element.scrollLeft')
@DocsEditable()
- void set scrollLeft(num value) => JS("void", "#.scrollLeft = #", this, value.round());
+ void set scrollLeft(int value) => JS("void", "#.scrollLeft = #", this, value.round());
@DomName('Element.scrollTop')
@DocsEditable()
- num get scrollTop => JS('num', '#.scrollTop', this).round();
+ int get scrollTop => JS('int', '#.scrollTop', this).round();
@DomName('Element.scrollTop')
@DocsEditable()
- void set scrollTop(num value) => JS("void", "#.scrollTop = #", this, value.round());
+ void set scrollTop(int value) => JS("void", "#.scrollTop = #", this, value.round());
@DomName('Element.scrollWidth')
@DocsEditable()
- num get scrollWidth => JS('num', '#.scrollWidth', this).round();
+ int get scrollWidth => JS('int', '#.scrollWidth', this).round();
$else
@DomName('Element.offsetHeight')
@DocsEditable()
- num get offsetHeight => _blink.Native_Element_offsetHeight_Getter(this).round();
+ int get offsetHeight => _blink.Native_Element_offsetHeight_Getter(this).round();
@DomName('Element.offsetLeft')
@DocsEditable()
- num get offsetLeft => _blink.Native_Element_offsetLeft_Getter(this).round();
+ int get offsetLeft => _blink.Native_Element_offsetLeft_Getter(this).round();
@DomName('Element.offsetTop')
@DocsEditable()
- num get offsetTop => _blink.Native_Element_offsetTop_Getter(this).round();
+ int get offsetTop => _blink.Native_Element_offsetTop_Getter(this).round();
@DomName('Element.offsetWidth')
@DocsEditable()
- num get offsetWidth => _blink.Native_Element_offsetWidth_Getter(this).round();
+ int get offsetWidth => _blink.Native_Element_offsetWidth_Getter(this).round();
@DomName('Element.clientHeight')
@DocsEditable()
- num get clientHeight => _blink.Native_Element_clientHeight_Getter(this).round();
+ int get clientHeight => _blink.Native_Element_clientHeight_Getter(this).round();
@DomName('Element.clientLeft')
@DocsEditable()
- num get clientLeft => _blink.Native_Element_clientLeft_Getter(this).round();
+ int get clientLeft => _blink.Native_Element_clientLeft_Getter(this).round();
@DomName('Element.clientTop')
@DocsEditable()
- num get clientTop => _blink.Native_Element_clientTop_Getter(this).round();
+ int get clientTop => _blink.Native_Element_clientTop_Getter(this).round();
@DomName('Element.clientWidth')
@DocsEditable()
- num get clientWidth => _blink.Native_Element_clientWidth_Getter(this).round();
+ int get clientWidth => _blink.Native_Element_clientWidth_Getter(this).round();
@DomName('Element.scrollHeight')
@DocsEditable()
- num get scrollHeight => _blink.Native_Element_scrollHeight_Getter(this).round();
+ int get scrollHeight => _blink.Native_Element_scrollHeight_Getter(this).round();
@DomName('Element.scrollLeft')
@DocsEditable()
- num get scrollLeft => _blink.Native_Element_scrollLeft_Getter(this).round();
+ int get scrollLeft => _blink.Native_Element_scrollLeft_Getter(this).round();
@DomName('Element.scrollLeft')
@DocsEditable()
- void set scrollLeft(num value) => _blink.Native_Element_scrollLeft_Setter(this, value.round());
+ void set scrollLeft(int value) => _blink.Native_Element_scrollLeft_Setter(this, value.round());
@DomName('Element.scrollTop')
@DocsEditable()
- num get scrollTop => _blink.Native_Element_scrollTop_Getter(this).round();
+ int get scrollTop => _blink.Native_Element_scrollTop_Getter(this).round();
@DomName('Element.scrollTop')
@DocsEditable()
- void set scrollTop(num value) => _blink.Native_Element_scrollTop_Setter(this, value.round());
+ void set scrollTop(int value) => _blink.Native_Element_scrollTop_Setter(this, value.round());
@DomName('Element.scrollWidth')
@DocsEditable()
- num get scrollWidth => _blink.Native_Element_scrollWidth_Getter(this).round();
+ int get scrollWidth => _blink.Native_Element_scrollWidth_Getter(this).round();
$endif
$!MEMBERS
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698