Issue 312703002: Update tree walking to not update a list while iterating over it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 312703002: Update tree walking to not update a list while iterating over it. (Closed)

Created:
6 years, 6 months ago by qsr

Modified:
6 years, 6 months ago

Reviewers:
bulach, brettw

Base URL:
https://chromium.googlesource.com/chromium/buildtools.git@master

Visibility:
Public.

Update tree walking to not update a list while iterating over it. It is not correct, in python, to modify a list while iterating over it.

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -14 lines)			Patch
	M	tools/checkdeps/java_checker.py	View	1	1 chunk	+17 lines, -14 lines	0 comments	Download

Total messages: 9 (0 generated)

qsr

Modifying a list in python while traversing it doesn't work correctly: >>> list = range(10) ...

6 years, 6 months ago (2014-06-03 09:26:03 UTC) #1

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 6 months ago (2014-06-03 17:11:09 UTC) #5

commit-bot: I haz the power

Commit queue rejected this change because it did not recognize the base URL. Please commit ...

6 years, 6 months ago (2014-06-03 17:11:09 UTC) #6

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 6 months ago (2014-06-03 17:23:22 UTC) #8

commit-bot: I haz the power

6 years, 6 months ago (2014-06-03 17:23:22 UTC) #9

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.