chrome/browser/automation/automation_provider_observers.h - Issue 3127008: Preliminary work on resuming downloads whose connections have expired.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_provider_observers.h

Issue 3127008: Preliminary work on resuming downloads whose connections have expired.

Patch Set: Waiting to send download automation error message until after other downloads are canceled. Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/automation/automation_provider_observers.cc » ('j') | chrome/browser/automation/automation_provider_observers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/automation_provider_observers.h

diff --git a/chrome/browser/automation/automation_provider_observers.h b/chrome/browser/automation/automation_provider_observers.h

index 949a59423f5cffcf896df880a632cde5f4477295..cfcd045b4d7c709c77b2e1a1f296aa685dd6e37b 100644

--- a/chrome/browser/automation/automation_provider_observers.h

+++ b/chrome/browser/automation/automation_provider_observers.h

@@ -663,21 +663,26 @@ class AutomationProviderDownloadItemObserver : public DownloadItem::Observer {

AutomationProviderDownloadItemObserver(

AutomationProvider* provider,

IPC::Message* reply_message,

- int downloads) {

- provider_ = provider;

- reply_message_ = reply_message;

- downloads_ = downloads;

+ int downloads)

+ : provider_(provider),

+ reply_message_(reply_message),

+ downloads_(downloads),

+ interrupted_(false) {

}

virtual ~AutomationProviderDownloadItemObserver() {}

- virtual void OnDownloadUpdated(DownloadItem* download) { }

+ virtual void OnDownloadUpdated(DownloadItem* download);

virtual void OnDownloadFileCompleted(DownloadItem* download);

virtual void OnDownloadOpened(DownloadItem* download) { }

+ virtual void OnDownloadInterrupted(DownloadItem* download);

private:

+ void RemoveAndCleanupOnLastEntry(DownloadItem* download);

AutomationProvider* provider_;

IPC::Message* reply_message_;

int downloads_;

+ bool interrupted_;

DISALLOW_COPY_AND_ASSIGN(AutomationProviderDownloadItemObserver);

};

@@ -698,6 +703,7 @@ class AutomationProviderDownloadUpdatedObserver

virtual void OnDownloadUpdated(DownloadItem* download);

virtual void OnDownloadOpened(DownloadItem* download);

virtual void OnDownloadFileCompleted(DownloadItem* download) { }

+ virtual void OnDownloadInterrupted(DownloadItem* download) { }

private:

AutomationProvider* provider_;