Preliminary work on resuming downloads whose connections have expired.

chrome/browser/automation/automation_provider_observers.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/automation_provider_observers.h"
 
 #include "base/basictypes.h"
 #include "base/json/json_writer.h"
 #include "base/string_util.h"
 #include "chrome/app/chrome_dll_resource.h"
@@ skipping 1116 matching lines @@
   model_->RemoveObserver(this);
 }
 
 void AutomationProviderBookmarkModelObserver::ReplyAndDelete(bool success) {
   AutomationMsg_WaitForBookmarkModelToLoad::WriteReplyParams(
       reply_message_, success);
   automation_provider_->Send(reply_message_);
   delete this;
 }
 
+void AutomationProviderDownloadItemObserver::OnDownloadUpdated(
+    DownloadItem* download) {
+  // If any download was interrupted, on the next update each outstanding
+  // download is cancelled.
+  if (interrupted_) {
+    download->Cancel(false);
+    RemoveAndCleanupOnLastEntry(download);
+  }
+}
+
 void AutomationProviderDownloadItemObserver::OnDownloadFileCompleted(
     DownloadItem* download) {
+  RemoveAndCleanupOnLastEntry(download);
+}
+
+void AutomationProviderDownloadItemObserver::OnDownloadInterrupted(

[Paweł Hajdan Jr., 2010/10/01 09:03:55]

This is broken, as said in http://codereview.chromium.org/3273013/show

+    DownloadItem* download) {
+  // Mark as interrupted.
+  interrupted_ = true;
+  // Cancel, so we don't pop up a dialog on exit.
+  download->Cancel(false);
+  RemoveAndCleanupOnLastEntry(download);
+}
+
+// We don't want to send multiple messages, as the behavior is undefined.
+// Set |interrupted_| on error, and on the last download completed/
+// interrupted, send either an error or a success message.
+void AutomationProviderDownloadItemObserver::RemoveAndCleanupOnLastEntry(
+    DownloadItem* download) {
+  // Forget about the download.
   download->RemoveObserver(this);
+  // If we are observing no more downloads, clean up.
   if (--downloads_ == 0) {
-    AutomationJSONReply(provider_, reply_message_).SendSuccess(NULL);
+    if (interrupted_) {
+      AutomationJSONReply(provider_, reply_message_).SendError(
+          "Download Interrupted");
+    } else {
+      AutomationJSONReply(provider_, reply_message_).SendSuccess(NULL);
+    }
     delete this;
   }
 }
 
 void AutomationProviderDownloadUpdatedObserver::OnDownloadUpdated(
     DownloadItem* download) {
   // If this observer is watching for open, only send the reply if the download
   // has been auto-opened.
   if (wait_for_open_ && !download->auto_opened())
     return;
@@ skipping 150 matching lines @@
     const NotificationSource& source,
     const NotificationDetails& details) {
   if (type == NotificationType::SAVE_PACKAGE_SUCCESSFULLY_FINISHED) {
     AutomationJSONReply(automation_, reply_message_).SendSuccess(NULL);
     delete this;
   } else {
     NOTREACHED();
   }
 }