Source/core/html/HTMLSelectElement.idl - Issue 312683005: IDL: Support optional argument default value syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.idl

Issue 312683005: IDL: Support optional argument default value syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address nits Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSelectElement.idl

diff --git a/Source/core/html/HTMLSelectElement.idl b/Source/core/html/HTMLSelectElement.idl

index 39974cdc64f25818907a208c42bedff16eedc251..52a124495f932a7c716c1d10bd0744669c5c0d5f 100644

--- a/Source/core/html/HTMLSelectElement.idl

+++ b/Source/core/html/HTMLSelectElement.idl

@@ -38,7 +38,7 @@ interface HTMLSelectElement : HTMLElement {

getter Element item(unsigned long index);

Element namedItem([Default=Undefined] optional DOMString name);

// FIXME: should be union type http://crbug.com/240176

- [RaisesException, TypeChecking=Interface] void add(HTMLElement element, [Default=Null] optional HTMLElement? before);

+ [RaisesException, TypeChecking=Interface] void add(HTMLElement element, optional HTMLElement? before = null);

[ImplementedAs=addBeforeOptionAtIndex, RaisesException, TypeChecking=Interface] void add(HTMLElement element, long before);

[RaisesException] void remove(); // ChildNode overload

void remove(long index);

« no previous file with comments | « Source/core/html/HTMLOptionElement.idl ('k') | Source/core/html/HTMLTextAreaElement.idl » ('j') | no next file with comments »