Source/core/css/FontFaceSet.idl - Issue 312683005: IDL: Support optional argument default value syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/FontFaceSet.idl

Issue 312683005: IDL: Support optional argument default value syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address nits Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/FontFaceSet.idl

diff --git a/Source/core/css/FontFaceSet.idl b/Source/core/css/FontFaceSet.idl

index c051b27cf4fa8ed18d51fcf68d7a42d2c81d3411..f1055517c102fea0198a073e567106f9af95cb70 100644

--- a/Source/core/css/FontFaceSet.idl

+++ b/Source/core/css/FontFaceSet.idl

@@ -41,8 +41,8 @@ enum FontFaceSetLoadStatus { "loading", "loaded" };

attribute EventHandler onloadingdone;

attribute EventHandler onloadingerror;

- [RaisesException] boolean check(DOMString font, [Default=NullString] optional DOMString text);

- [CallWith=ScriptState] Promise load(DOMString font, [Default=NullString] optional DOMString text);

+ [RaisesException] boolean check(DOMString font, optional DOMString text = null);

+ [CallWith=ScriptState] Promise load(DOMString font, optional DOMString text = null);

[CallWith=ScriptState] Promise ready();

[RaisesException] void add(FontFace fontFace);

« no previous file with comments | « Source/core/css/CSSStyleDeclaration.idl ('k') | Source/core/css/WebKitCSSMatrix.idl » ('j') | no next file with comments »