Source/bindings/v8/V8Binding.cpp - Issue 312683005: IDL: Support optional argument default value syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Binding.cpp

Issue 312683005: IDL: Support optional argument default value syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/v8_methods.py ('K') | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/core/css/CSSStyleDeclaration.idl » ('j') | Source/core/html/HTMLSelectElement.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/V8Binding.cpp

diff --git a/Source/bindings/v8/V8Binding.cpp b/Source/bindings/v8/V8Binding.cpp

index bef984e7af5aff1ac0aafda305d59436dbe6173d..88192b78c1754962653549e4a784cd6ae0fe0b84 100644

--- a/Source/bindings/v8/V8Binding.cpp

+++ b/Source/bindings/v8/V8Binding.cpp

@@ -494,7 +494,7 @@ float toFloat(v8::Handle<v8::Value> value, ExceptionState& exceptionState)

String toByteString(v8::Handle<v8::Value> value, ExceptionState& exceptionState)

{

- // Handle [Default=NullString]

+ // Handle null default value.

if (value.IsEmpty())

return String();